-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten header structure #132
Comments
It seems to me that the point 2 is blocking and I like a lot the possibility of distributing iDynTree in OS X as a framework. |
I like this idea a lot and I dont think issue 2 is a major problem since at Naveen Kuppuswamy, PhD On Wed, Feb 3, 2016 at 10:19 AM, Daniele notifications@github.com wrote:
|
Yes,
|
Furthermore, fix various issues around in the code. The spreading of code related to this in the library is suboptimal, and mostly due to the fact that model functions can't depend on sensors data structure. The definite fix for this is to merge the model and sensors libraries, but this require that first we solve this issue: #132 .
fyi @Nicogene , I am now working in solving this. |
Currently, we are using and installing headers with the following structure:
This was mostly inherited by the structure used in yarp and icub.
For several reasons, I am now inclined to migrate as soon as possible to a structure like:
The reasons are:
iDynTree
, for consistency with bindings in which classes and function are found in theiDynTree
module in python, in theiDynTree
package in Matlab, etc, etc. The double layer headers in yarp and icub is used also to be consistent with a double layer structure of namespace.Model
and theSensors
component in a single library (to create sensors-aware model transformers) but one big blocking issue is that cmake currently supports only one public header path for library unless you sensibly complicate the cmake (see https://github.com/robotology/idyntree/blob/master/src/sensors/CMakeLists.txt#L51). Hence moving headers between components wil always mean changing their header path, and that is clearly not desirable for backward compatibility with existing code. Having a single layer header structure will mean that we can move headers across components without problem, simplifyng refactoring.The change will only affect the new iDynTree-exclusive data structures, that are not currently used by any code external to iDynTree, so it should be harmless.
Any opinions on this change?
cc @francesco-romano @nunoguedelha @DanielePucci @naveenoid @fjandrad
The text was updated successfully, but these errors were encountered: