Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI in Windows with HumanStateVisualizer #232

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Conversation

lrapetti
Copy link
Member

@lrapetti lrapetti commented Jan 29, 2021

This PR should fix the failure in Windows CI (https://github.com/robotology/human-dynamics-estimation/runs/1790878536#step:9:10886) as in robotology/idyntree#806.

Moreover, I have enabled the compilation of the HumanStateVisualizer

@lrapetti lrapetti added this to the AnDy - Iteration 55 milestone Jan 29, 2021
@lrapetti lrapetti self-assigned this Jan 29, 2021
Copy link
Member

@yeshasvitirupachuri yeshasvitirupachuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lrapetti

@lrapetti
Copy link
Member Author

lrapetti commented Jan 29, 2021

I thought that updating the vcpkg-robotology tag would have fixed the compilation since irrlicht was recentrly included (robotology/robotology-superbuild-dependencies-vcpkg#39), but it seems to be still failing with the error:

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
D:/a/human-dynamics-estimation/human-dynamics-estimation/iDynTree/src/visualization/IRRLICHT_INCLUDE_DIR
   used as include directory in directory D:/a/human-dynamics-estimation/human-dynamics-estimation/iDynTree/src/visualization

@traversaro
Copy link
Member

I thought that updating the vcpkg-robotology tag would have fixed the compilation since irrlicht was recentrly included (robotology/robotology-superbuild-dependencies-vcpkg#39), but it seems to be still failing with the error:

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
D:/a/human-dynamics-estimation/human-dynamics-estimation/iDynTree/src/visualization/IRRLICHT_INCLUDE_DIR
   used as include directory in directory D:/a/human-dynamics-estimation/human-dynamics-estimation/iDynTree/src/visualization

I guess you found it, but this was fixed by robotology/idyntree#806 .

@lrapetti
Copy link
Member Author

lrapetti commented Feb 1, 2021

I guess you found it, but this was fixed by robotology/idyntree#806 .

thanks, yes I have noticed that change, indeed I tried to change the tag to devel and I am waiting to see if that fixes the problem (If I am not wrong, that change has not been included in a release yet).

@traversaro
Copy link
Member

I guess you found it, but this was fixed by robotology/idyntree#806 .

thanks, yes I have noticed that change, indeed I tried to change the tag to devel and I am waiting to see if that fixes the problem (If I am not wrong, that change has not been included in a release yet).

No, it was not included in a release yet, hopefully we should close iDynTree 3 soon.

@lrapetti
Copy link
Member Author

lrapetti commented Feb 1, 2021

All the checks are now passed.

At this stage I think we can use the devel branch in CI as long as we don't have the iDyntree release,
what do you think @traversaro ? Would it be better to use directly a commit tag?
Consider that after merging this PR we are planning to do a new release (#231).

@traversaro
Copy link
Member

I think devel is ok.

@lrapetti
Copy link
Member Author

lrapetti commented Feb 1, 2021

I think devel is ok.

Great! Merging

@lrapetti lrapetti merged commit 27268a9 into master Feb 1, 2021
This was referenced Feb 1, 2021
@yeshasvitirupachuri yeshasvitirupachuri deleted the fix-CI-irricht-windows branch February 3, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants