Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A different take on webcrypto #139

Closed
wants to merge 4 commits into from

Conversation

hurrymaplelad
Copy link
Contributor

Depends on #138

Alternative to #111 that adds webcrypto as an option (--implementation webcrypto) while keeping CryptoJS as the default.

Supporting webcrypto required most of the impl interface methods to become async (aka return Promises). Requiring promise likely limits the browsers we'd support, though corejs and others offer easy polyfills.

I'm curious what browsers we'd like to support. Using async/await outside the webcrypto implementation (which already requires more advanced features) would clean up the codec code quite a bit.

@robinmoisson
Copy link
Owner

WebCrypto is now used in StatiCrypt 🎉

The code was merged in #164 and relies a lot on the approach you took here. SC 2.x supports both CryptoJS and WebCrypto, and because I wanted to stay as compatible as possible with custom templates it's pretty noisy, but it should become much clearer in SC 3.x where WebCrypto will be the only option (the WIP branch is already here).

Thanks a lot for your contributions to the project, they have been really useful and definitely made it better. 🙂

@oleteacher
Copy link
Contributor

Great work, thank you for all your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants