Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #138
Alternative to #111 that adds webcrypto as an option (
--implementation webcrypto
) while keeping CryptoJS as the default.Supporting webcrypto required most of the
impl
interface methods to become async (aka return Promises). Requiring promise likely limits the browsers we'd support, though corejs and others offer easy polyfills.I'm curious what browsers we'd like to support. Using
async/await
outside the webcrypto implementation (which already requires more advanced features) would clean up the codec code quite a bit.