Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #137
This diff tackles point 2 from #137 - lots of crypto code is duplicated.
This problem seems worth solving both to make sure the crypto functions evolve consistently, and to reduce merge and rebase pain for contributors.
See
transcludeModule
for the crux of this diff. We use a very simple CommonJS -> browser transform to share some pure functions between the node CLI and browser.The extra separation between
codec.js
andimpl-cryptojs.js
paves the way for easily switching between CryptoJS and WebCrypto.