Disable pallet uniques calls

[ilionic]

Fixes #151
Fixes #150

[HashWarlock]

Looks good.

[bmacer]

Looks good. I tried to implement a test of this on rmrk-core but failed. Not sure how I did it wrong.

I added this to the mock.rs

rmrk-substrate/runtime/src/lib.rs

Lines 169 to 193 in 036cc63

	pub struct BaseFilter;
	impl Contains<Call> for BaseFilter {
	fn contains(call: &Call) -> bool {
	// Disable direct calls to pallet_uniques
	!matches!(
	call,
	Call::Uniques(pallet_uniques::Call::approve_transfer { .. }) |
	Call::Uniques(pallet_uniques::Call::burn { .. }) |
	Call::Uniques(pallet_uniques::Call::cancel_approval { .. }) |
	Call::Uniques(pallet_uniques::Call::clear_class_metadata { .. }) |
	Call::Uniques(pallet_uniques::Call::clear_metadata { .. }) |
	Call::Uniques(pallet_uniques::Call::create { .. }) |
	Call::Uniques(pallet_uniques::Call::destroy { .. }) |
	Call::Uniques(pallet_uniques::Call::force_asset_status { .. }) |
	Call::Uniques(pallet_uniques::Call::force_create { .. }) |
	Call::Uniques(pallet_uniques::Call::freeze_class { .. }) |
	Call::Uniques(pallet_uniques::Call::mint { .. }) |
	Call::Uniques(pallet_uniques::Call::redeposit { .. }) |
	Call::Uniques(pallet_uniques::Call::set_class_metadata { .. }) |
	Call::Uniques(pallet_uniques::Call::thaw_class { .. }) |
	Call::Uniques(pallet_uniques::Call::transfer { .. }) |
	Call::Uniques(pallet_uniques::Call::transfer_ownership { .. })
	)
	}
	}

Changed BaseCallFilter to equal BaseFilter

rmrk-substrate/runtime/src/lib.rs

Line 199 in 036cc63

type BaseCallFilter = BaseFilter;

And wrote this test (not really a test yet just a println, but the result is unexpected/unwanted "Ok(())"

/// Uniques: Unable to call directly
#[test]
fn calling_uniques_directly_fails() {
	ExtBuilder::default().build().execute_with(|| {
		println!("{:?}", Uniques::create(Origin::signed(ALICE),1, ALICE));
	});
}

If a test for this doesn't matter that much, go ahead and merge. Otherwise, any ideas?

[bmacer]

Looks good unless you want to pursue testing this behavior

[HashWarlock]

Looks good. I tried to implement a test of this on rmrk-core but failed. Not sure how I did it wrong.

I added this to the mock.rs

rmrk-substrate/runtime/src/lib.rs

Lines 169 to 193 in 036cc63

	pub struct BaseFilter;
	impl Contains<Call> for BaseFilter {
	fn contains(call: &Call) -> bool {
	// Disable direct calls to pallet_uniques
	!matches!(
	call,
	Call::Uniques(pallet_uniques::Call::approve_transfer { .. }) |
	Call::Uniques(pallet_uniques::Call::burn { .. }) |
	Call::Uniques(pallet_uniques::Call::cancel_approval { .. }) |
	Call::Uniques(pallet_uniques::Call::clear_class_metadata { .. }) |
	Call::Uniques(pallet_uniques::Call::clear_metadata { .. }) |
	Call::Uniques(pallet_uniques::Call::create { .. }) |
	Call::Uniques(pallet_uniques::Call::destroy { .. }) |
	Call::Uniques(pallet_uniques::Call::force_asset_status { .. }) |
	Call::Uniques(pallet_uniques::Call::force_create { .. }) |
	Call::Uniques(pallet_uniques::Call::freeze_class { .. }) |
	Call::Uniques(pallet_uniques::Call::mint { .. }) |
	Call::Uniques(pallet_uniques::Call::redeposit { .. }) |
	Call::Uniques(pallet_uniques::Call::set_class_metadata { .. }) |
	Call::Uniques(pallet_uniques::Call::thaw_class { .. }) |
	Call::Uniques(pallet_uniques::Call::transfer { .. }) |
	Call::Uniques(pallet_uniques::Call::transfer_ownership { .. })
	)
	}
	}

Changed BaseCallFilter to equal BaseFilter

rmrk-substrate/runtime/src/lib.rs

Line 199 in 036cc63

type BaseCallFilter = BaseFilter;

And wrote this test (not really a test yet just a println, but the result is unexpected/unwanted "Ok(())"

/// Uniques: Unable to call directly
#[test]
fn calling_uniques_directly_fails() {
	ExtBuilder::default().build().execute_with(|| {
		println!("{:?}", Uniques::create(Origin::signed(ALICE),1, ALICE));
	});
}

If a test for this doesn't matter that much, go ahead and merge. Otherwise, any ideas?

Check out the test file in substrate and this example https://github.com/paritytech/substrate/blob/master/frame/utility/src/tests.rs#L277-L292

We should get an frame_system::Error::<Test>::CallFiltered.

[ilionic]

Will merge for now as filtered Calls not part of rmrk pallets technically. But I guess good to add a test anyway