This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
/
Copy pathtests.rs
939 lines (849 loc) · 28.4 KB
/
tests.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
// This file is part of Substrate.
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: Apache-2.0
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Tests for Utility Pallet
#![cfg(test)]
use super::*;
use crate as utility;
use frame_support::{
assert_err_ignore_postinfo, assert_noop, assert_ok,
dispatch::{DispatchError, DispatchErrorWithPostInfo, Dispatchable, Pays},
error::BadOrigin,
parameter_types, storage,
traits::{ConstU32, ConstU64, Contains},
weights::Weight,
};
use pallet_collective::{EnsureProportionAtLeast, Instance1};
use sp_core::H256;
use sp_runtime::{
traits::{BlakeTwo256, Hash, IdentityLookup},
BuildStorage, TokenError,
};
type BlockNumber = u64;
// example module to test behaviors.
#[frame_support::pallet(dev_mode)]
pub mod example {
use frame_support::{dispatch::WithPostDispatchInfo, pallet_prelude::*};
use frame_system::pallet_prelude::*;
#[pallet::pallet]
pub struct Pallet<T>(_);
#[pallet::config]
pub trait Config: frame_system::Config {}
#[pallet::call]
impl<T: Config> Pallet<T> {
#[pallet::call_index(0)]
#[pallet::weight(*_weight)]
pub fn noop(_origin: OriginFor<T>, _weight: Weight) -> DispatchResult {
Ok(())
}
#[pallet::call_index(1)]
#[pallet::weight(*_start_weight)]
pub fn foobar(
origin: OriginFor<T>,
err: bool,
_start_weight: Weight,
end_weight: Option<Weight>,
) -> DispatchResultWithPostInfo {
let _ = ensure_signed(origin)?;
if err {
let error: DispatchError = "The cake is a lie.".into();
if let Some(weight) = end_weight {
Err(error.with_weight(weight))
} else {
Err(error)?
}
} else {
Ok(end_weight.into())
}
}
#[pallet::call_index(2)]
#[pallet::weight(0)]
pub fn big_variant(_origin: OriginFor<T>, _arg: [u8; 400]) -> DispatchResult {
Ok(())
}
}
}
mod mock_democracy {
pub use pallet::*;
#[frame_support::pallet(dev_mode)]
pub mod pallet {
use frame_support::pallet_prelude::*;
use frame_system::pallet_prelude::*;
#[pallet::pallet]
pub struct Pallet<T>(_);
#[pallet::config]
pub trait Config: frame_system::Config + Sized {
type RuntimeEvent: From<Event<Self>>
+ IsType<<Self as frame_system::Config>::RuntimeEvent>;
type ExternalMajorityOrigin: EnsureOrigin<Self::RuntimeOrigin>;
}
#[pallet::call]
impl<T: Config> Pallet<T> {
#[pallet::call_index(3)]
#[pallet::weight(0)]
pub fn external_propose_majority(origin: OriginFor<T>) -> DispatchResult {
T::ExternalMajorityOrigin::ensure_origin(origin)?;
Self::deposit_event(Event::<T>::ExternalProposed);
Ok(())
}
}
#[pallet::event]
#[pallet::generate_deposit(pub(super) fn deposit_event)]
pub enum Event<T: Config> {
ExternalProposed,
}
}
}
type Block = frame_system::mocking::MockBlock<Test>;
frame_support::construct_runtime!(
pub enum Test
{
System: frame_system::{Pallet, Call, Config<T>, Storage, Event<T>},
Timestamp: pallet_timestamp::{Call, Inherent},
Balances: pallet_balances::{Pallet, Call, Storage, Config<T>, Event<T>},
RootTesting: pallet_root_testing::{Pallet, Call, Storage},
Council: pallet_collective::<Instance1>,
Utility: utility::{Pallet, Call, Event},
Example: example::{Pallet, Call},
Democracy: mock_democracy::{Pallet, Call, Event<T>},
}
);
parameter_types! {
pub BlockWeights: frame_system::limits::BlockWeights =
frame_system::limits::BlockWeights::simple_max(Weight::MAX);
}
impl frame_system::Config for Test {
type BaseCallFilter = TestBaseCallFilter;
type BlockWeights = BlockWeights;
type BlockLength = ();
type DbWeight = ();
type RuntimeOrigin = RuntimeOrigin;
type Nonce = u64;
type Hash = H256;
type RuntimeCall = RuntimeCall;
type Hashing = BlakeTwo256;
type AccountId = u64;
type Lookup = IdentityLookup<Self::AccountId>;
type Block = Block;
type RuntimeEvent = RuntimeEvent;
type BlockHashCount = ConstU64<250>;
type Version = ();
type PalletInfo = PalletInfo;
type AccountData = pallet_balances::AccountData<u64>;
type OnNewAccount = ();
type OnKilledAccount = ();
type SystemWeightInfo = frame_system::weights::SubstrateWeight<Test>;
type SS58Prefix = ();
type OnSetCode = ();
type MaxConsumers = ConstU32<16>;
}
impl pallet_balances::Config for Test {
type MaxLocks = ();
type MaxReserves = ();
type ReserveIdentifier = [u8; 8];
type Balance = u64;
type DustRemoval = ();
type RuntimeEvent = RuntimeEvent;
type ExistentialDeposit = ConstU64<1>;
type AccountStore = System;
type WeightInfo = ();
type FreezeIdentifier = ();
type MaxFreezes = ();
type RuntimeHoldReason = ();
type MaxHolds = ();
}
impl pallet_root_testing::Config for Test {}
impl pallet_timestamp::Config for Test {
type Moment = u64;
type OnTimestampSet = ();
type MinimumPeriod = ConstU64<3>;
type WeightInfo = ();
}
const MOTION_DURATION_IN_BLOCKS: BlockNumber = 3;
parameter_types! {
pub const MultisigDepositBase: u64 = 1;
pub const MultisigDepositFactor: u64 = 1;
pub const MaxSignatories: u32 = 3;
pub const MotionDuration: BlockNumber = MOTION_DURATION_IN_BLOCKS;
pub const MaxProposals: u32 = 100;
pub const MaxMembers: u32 = 100;
pub MaxProposalWeight: Weight = sp_runtime::Perbill::from_percent(50) * BlockWeights::get().max_block;
}
type CouncilCollective = pallet_collective::Instance1;
impl pallet_collective::Config<CouncilCollective> for Test {
type RuntimeOrigin = RuntimeOrigin;
type Proposal = RuntimeCall;
type RuntimeEvent = RuntimeEvent;
type MotionDuration = MotionDuration;
type MaxProposals = MaxProposals;
type MaxMembers = MaxMembers;
type DefaultVote = pallet_collective::PrimeDefaultVote;
type WeightInfo = ();
type SetMembersOrigin = frame_system::EnsureRoot<Self::AccountId>;
type MaxProposalWeight = MaxProposalWeight;
}
impl example::Config for Test {}
pub struct TestBaseCallFilter;
impl Contains<RuntimeCall> for TestBaseCallFilter {
fn contains(c: &RuntimeCall) -> bool {
match *c {
// Transfer works. Use `transfer_keep_alive` for a call that doesn't pass the filter.
RuntimeCall::Balances(pallet_balances::Call::transfer_allow_death { .. }) => true,
RuntimeCall::Utility(_) => true,
// For benchmarking, this acts as a noop call
RuntimeCall::System(frame_system::Call::remark { .. }) => true,
// For tests
RuntimeCall::Example(_) => true,
// For council origin tests.
RuntimeCall::Democracy(_) => true,
_ => false,
}
}
}
impl mock_democracy::Config for Test {
type RuntimeEvent = RuntimeEvent;
type ExternalMajorityOrigin = EnsureProportionAtLeast<u64, Instance1, 3, 4>;
}
impl Config for Test {
type RuntimeEvent = RuntimeEvent;
type RuntimeCall = RuntimeCall;
type PalletsOrigin = OriginCaller;
type WeightInfo = ();
}
type ExampleCall = example::Call<Test>;
type UtilityCall = crate::Call<Test>;
use frame_system::Call as SystemCall;
use pallet_balances::Call as BalancesCall;
use pallet_root_testing::Call as RootTestingCall;
use pallet_timestamp::Call as TimestampCall;
pub fn new_test_ext() -> sp_io::TestExternalities {
let mut t = frame_system::GenesisConfig::<Test>::default().build_storage().unwrap();
pallet_balances::GenesisConfig::<Test> {
balances: vec![(1, 10), (2, 10), (3, 10), (4, 10), (5, 2)],
}
.assimilate_storage(&mut t)
.unwrap();
pallet_collective::GenesisConfig::<Test, Instance1> {
members: vec![1, 2, 3],
phantom: Default::default(),
}
.assimilate_storage(&mut t)
.unwrap();
let mut ext = sp_io::TestExternalities::new(t);
ext.execute_with(|| System::set_block_number(1));
ext
}
fn call_transfer(dest: u64, value: u64) -> RuntimeCall {
RuntimeCall::Balances(BalancesCall::transfer_allow_death { dest, value })
}
fn call_foobar(err: bool, start_weight: Weight, end_weight: Option<Weight>) -> RuntimeCall {
RuntimeCall::Example(ExampleCall::foobar { err, start_weight, end_weight })
}
#[test]
fn as_derivative_works() {
new_test_ext().execute_with(|| {
let sub_1_0 = Utility::derivative_account_id(1, 0);
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), sub_1_0, 5));
assert_err_ignore_postinfo!(
Utility::as_derivative(RuntimeOrigin::signed(1), 1, Box::new(call_transfer(6, 3)),),
TokenError::FundsUnavailable,
);
assert_ok!(Utility::as_derivative(
RuntimeOrigin::signed(1),
0,
Box::new(call_transfer(2, 3)),
));
assert_eq!(Balances::free_balance(sub_1_0), 2);
assert_eq!(Balances::free_balance(2), 13);
});
}
#[test]
fn as_derivative_handles_weight_refund() {
new_test_ext().execute_with(|| {
let start_weight = Weight::from_parts(100, 0);
let end_weight = Weight::from_parts(75, 0);
let diff = start_weight - end_weight;
// Full weight when ok
let inner_call = call_foobar(false, start_weight, None);
let call = RuntimeCall::Utility(UtilityCall::as_derivative {
index: 0,
call: Box::new(inner_call),
});
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_ok!(result);
assert_eq!(extract_actual_weight(&result, &info), info.weight);
// Refund weight when ok
let inner_call = call_foobar(false, start_weight, Some(end_weight));
let call = RuntimeCall::Utility(UtilityCall::as_derivative {
index: 0,
call: Box::new(inner_call),
});
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_ok!(result);
// Diff is refunded
assert_eq!(extract_actual_weight(&result, &info), info.weight - diff);
// Full weight when err
let inner_call = call_foobar(true, start_weight, None);
let call = RuntimeCall::Utility(UtilityCall::as_derivative {
index: 0,
call: Box::new(inner_call),
});
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_noop!(
result,
DispatchErrorWithPostInfo {
post_info: PostDispatchInfo {
// No weight is refunded
actual_weight: Some(info.weight),
pays_fee: Pays::Yes,
},
error: DispatchError::Other("The cake is a lie."),
}
);
// Refund weight when err
let inner_call = call_foobar(true, start_weight, Some(end_weight));
let call = RuntimeCall::Utility(UtilityCall::as_derivative {
index: 0,
call: Box::new(inner_call),
});
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_noop!(
result,
DispatchErrorWithPostInfo {
post_info: PostDispatchInfo {
// Diff is refunded
actual_weight: Some(info.weight - diff),
pays_fee: Pays::Yes,
},
error: DispatchError::Other("The cake is a lie."),
}
);
});
}
#[test]
fn as_derivative_filters() {
new_test_ext().execute_with(|| {
assert_err_ignore_postinfo!(
Utility::as_derivative(
RuntimeOrigin::signed(1),
1,
Box::new(RuntimeCall::Balances(pallet_balances::Call::transfer_keep_alive {
dest: 2,
value: 1
})),
),
DispatchError::from(frame_system::Error::<Test>::CallFiltered),
);
});
}
#[test]
fn batch_with_root_works() {
new_test_ext().execute_with(|| {
let k = b"a".to_vec();
let call = RuntimeCall::System(frame_system::Call::set_storage {
items: vec![(k.clone(), k.clone())],
});
assert!(!TestBaseCallFilter::contains(&call));
assert_eq!(Balances::free_balance(1), 10);
assert_eq!(Balances::free_balance(2), 10);
assert_ok!(Utility::batch(
RuntimeOrigin::root(),
vec![
RuntimeCall::Balances(BalancesCall::force_transfer {
source: 1,
dest: 2,
value: 5
}),
RuntimeCall::Balances(BalancesCall::force_transfer {
source: 1,
dest: 2,
value: 5
}),
call, // Check filters are correctly bypassed
]
));
assert_eq!(Balances::free_balance(1), 0);
assert_eq!(Balances::free_balance(2), 20);
assert_eq!(storage::unhashed::get_raw(&k), Some(k));
});
}
#[test]
fn batch_with_signed_works() {
new_test_ext().execute_with(|| {
assert_eq!(Balances::free_balance(1), 10);
assert_eq!(Balances::free_balance(2), 10);
assert_ok!(Utility::batch(
RuntimeOrigin::signed(1),
vec![call_transfer(2, 5), call_transfer(2, 5)]
),);
assert_eq!(Balances::free_balance(1), 0);
assert_eq!(Balances::free_balance(2), 20);
});
}
#[test]
fn batch_with_signed_filters() {
new_test_ext().execute_with(|| {
assert_ok!(Utility::batch(
RuntimeOrigin::signed(1),
vec![RuntimeCall::Balances(pallet_balances::Call::transfer_keep_alive {
dest: 2,
value: 1
})]
),);
System::assert_last_event(
utility::Event::BatchInterrupted {
index: 0,
error: frame_system::Error::<Test>::CallFiltered.into(),
}
.into(),
);
});
}
#[test]
fn batch_early_exit_works() {
new_test_ext().execute_with(|| {
assert_eq!(Balances::free_balance(1), 10);
assert_eq!(Balances::free_balance(2), 10);
assert_ok!(Utility::batch(
RuntimeOrigin::signed(1),
vec![call_transfer(2, 5), call_transfer(2, 10), call_transfer(2, 5),]
),);
assert_eq!(Balances::free_balance(1), 5);
assert_eq!(Balances::free_balance(2), 15);
});
}
#[test]
fn batch_weight_calculation_doesnt_overflow() {
use sp_runtime::Perbill;
new_test_ext().execute_with(|| {
let big_call = RuntimeCall::RootTesting(RootTestingCall::fill_block {
ratio: Perbill::from_percent(50),
});
assert_eq!(big_call.get_dispatch_info().weight, Weight::MAX / 2);
// 3 * 50% saturates to 100%
let batch_call = RuntimeCall::Utility(crate::Call::batch {
calls: vec![big_call.clone(), big_call.clone(), big_call.clone()],
});
assert_eq!(batch_call.get_dispatch_info().weight, Weight::MAX);
});
}
#[test]
fn batch_handles_weight_refund() {
new_test_ext().execute_with(|| {
let start_weight = Weight::from_parts(100, 0);
let end_weight = Weight::from_parts(75, 0);
let diff = start_weight - end_weight;
let batch_len = 4;
// Full weight when ok
let inner_call = call_foobar(false, start_weight, None);
let batch_calls = vec![inner_call; batch_len as usize];
let call = RuntimeCall::Utility(UtilityCall::batch { calls: batch_calls });
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_ok!(result);
assert_eq!(extract_actual_weight(&result, &info), info.weight);
// Refund weight when ok
let inner_call = call_foobar(false, start_weight, Some(end_weight));
let batch_calls = vec![inner_call; batch_len as usize];
let call = RuntimeCall::Utility(UtilityCall::batch { calls: batch_calls });
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_ok!(result);
// Diff is refunded
assert_eq!(extract_actual_weight(&result, &info), info.weight - diff * batch_len);
// Full weight when err
let good_call = call_foobar(false, start_weight, None);
let bad_call = call_foobar(true, start_weight, None);
let batch_calls = vec![good_call, bad_call];
let call = RuntimeCall::Utility(UtilityCall::batch { calls: batch_calls });
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_ok!(result);
System::assert_last_event(
utility::Event::BatchInterrupted { index: 1, error: DispatchError::Other("") }.into(),
);
// No weight is refunded
assert_eq!(extract_actual_weight(&result, &info), info.weight);
// Refund weight when err
let good_call = call_foobar(false, start_weight, Some(end_weight));
let bad_call = call_foobar(true, start_weight, Some(end_weight));
let batch_calls = vec![good_call, bad_call];
let batch_len = batch_calls.len() as u64;
let call = RuntimeCall::Utility(UtilityCall::batch { calls: batch_calls });
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_ok!(result);
System::assert_last_event(
utility::Event::BatchInterrupted { index: 1, error: DispatchError::Other("") }.into(),
);
assert_eq!(extract_actual_weight(&result, &info), info.weight - diff * batch_len);
// Partial batch completion
let good_call = call_foobar(false, start_weight, Some(end_weight));
let bad_call = call_foobar(true, start_weight, Some(end_weight));
let batch_calls = vec![good_call, bad_call.clone(), bad_call];
let call = RuntimeCall::Utility(UtilityCall::batch { calls: batch_calls });
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_ok!(result);
System::assert_last_event(
utility::Event::BatchInterrupted { index: 1, error: DispatchError::Other("") }.into(),
);
assert_eq!(
extract_actual_weight(&result, &info),
// Real weight is 2 calls at end_weight
<Test as Config>::WeightInfo::batch(2) + end_weight * 2,
);
});
}
#[test]
fn batch_all_works() {
new_test_ext().execute_with(|| {
assert_eq!(Balances::free_balance(1), 10);
assert_eq!(Balances::free_balance(2), 10);
assert_ok!(Utility::batch_all(
RuntimeOrigin::signed(1),
vec![call_transfer(2, 5), call_transfer(2, 5)]
),);
assert_eq!(Balances::free_balance(1), 0);
assert_eq!(Balances::free_balance(2), 20);
});
}
#[test]
fn batch_all_revert() {
new_test_ext().execute_with(|| {
let call = call_transfer(2, 5);
let info = call.get_dispatch_info();
assert_eq!(Balances::free_balance(1), 10);
assert_eq!(Balances::free_balance(2), 10);
let batch_all_calls = RuntimeCall::Utility(crate::Call::<Test>::batch_all {
calls: vec![call_transfer(2, 5), call_transfer(2, 10), call_transfer(2, 5)],
});
assert_noop!(
batch_all_calls.dispatch(RuntimeOrigin::signed(1)),
DispatchErrorWithPostInfo {
post_info: PostDispatchInfo {
actual_weight: Some(
<Test as Config>::WeightInfo::batch_all(2) + info.weight * 2
),
pays_fee: Pays::Yes
},
error: TokenError::FundsUnavailable.into(),
}
);
assert_eq!(Balances::free_balance(1), 10);
assert_eq!(Balances::free_balance(2), 10);
});
}
#[test]
fn batch_all_handles_weight_refund() {
new_test_ext().execute_with(|| {
let start_weight = Weight::from_parts(100, 0);
let end_weight = Weight::from_parts(75, 0);
let diff = start_weight - end_weight;
let batch_len = 4;
// Full weight when ok
let inner_call = call_foobar(false, start_weight, None);
let batch_calls = vec![inner_call; batch_len as usize];
let call = RuntimeCall::Utility(UtilityCall::batch_all { calls: batch_calls });
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_ok!(result);
assert_eq!(extract_actual_weight(&result, &info), info.weight);
// Refund weight when ok
let inner_call = call_foobar(false, start_weight, Some(end_weight));
let batch_calls = vec![inner_call; batch_len as usize];
let call = RuntimeCall::Utility(UtilityCall::batch_all { calls: batch_calls });
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_ok!(result);
// Diff is refunded
assert_eq!(extract_actual_weight(&result, &info), info.weight - diff * batch_len);
// Full weight when err
let good_call = call_foobar(false, start_weight, None);
let bad_call = call_foobar(true, start_weight, None);
let batch_calls = vec![good_call, bad_call];
let call = RuntimeCall::Utility(UtilityCall::batch_all { calls: batch_calls });
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_err_ignore_postinfo!(result, "The cake is a lie.");
// No weight is refunded
assert_eq!(extract_actual_weight(&result, &info), info.weight);
// Refund weight when err
let good_call = call_foobar(false, start_weight, Some(end_weight));
let bad_call = call_foobar(true, start_weight, Some(end_weight));
let batch_calls = vec![good_call, bad_call];
let batch_len = batch_calls.len() as u64;
let call = RuntimeCall::Utility(UtilityCall::batch_all { calls: batch_calls });
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_err_ignore_postinfo!(result, "The cake is a lie.");
assert_eq!(extract_actual_weight(&result, &info), info.weight - diff * batch_len);
// Partial batch completion
let good_call = call_foobar(false, start_weight, Some(end_weight));
let bad_call = call_foobar(true, start_weight, Some(end_weight));
let batch_calls = vec![good_call, bad_call.clone(), bad_call];
let call = RuntimeCall::Utility(UtilityCall::batch_all { calls: batch_calls });
let info = call.get_dispatch_info();
let result = call.dispatch(RuntimeOrigin::signed(1));
assert_err_ignore_postinfo!(result, "The cake is a lie.");
assert_eq!(
extract_actual_weight(&result, &info),
// Real weight is 2 calls at end_weight
<Test as Config>::WeightInfo::batch_all(2) + end_weight * 2,
);
});
}
#[test]
fn batch_all_does_not_nest() {
new_test_ext().execute_with(|| {
let batch_all = RuntimeCall::Utility(UtilityCall::batch_all {
calls: vec![call_transfer(2, 1), call_transfer(2, 1), call_transfer(2, 1)],
});
let info = batch_all.get_dispatch_info();
assert_eq!(Balances::free_balance(1), 10);
assert_eq!(Balances::free_balance(2), 10);
// A nested batch_all call will not pass the filter, and fail with `BadOrigin`.
assert_noop!(
Utility::batch_all(RuntimeOrigin::signed(1), vec![batch_all.clone()]),
DispatchErrorWithPostInfo {
post_info: PostDispatchInfo {
actual_weight: Some(<Test as Config>::WeightInfo::batch_all(1) + info.weight),
pays_fee: Pays::Yes
},
error: frame_system::Error::<Test>::CallFiltered.into(),
}
);
// And for those who want to get a little fancy, we check that the filter persists across
// other kinds of dispatch wrapping functions... in this case
// `batch_all(batch(batch_all(..)))`
let batch_nested = RuntimeCall::Utility(UtilityCall::batch { calls: vec![batch_all] });
// Batch will end with `Ok`, but does not actually execute as we can see from the event
// and balances.
assert_ok!(Utility::batch_all(RuntimeOrigin::signed(1), vec![batch_nested]));
System::assert_has_event(
utility::Event::BatchInterrupted {
index: 0,
error: frame_system::Error::<Test>::CallFiltered.into(),
}
.into(),
);
assert_eq!(Balances::free_balance(1), 10);
assert_eq!(Balances::free_balance(2), 10);
});
}
#[test]
fn batch_limit() {
new_test_ext().execute_with(|| {
let calls = vec![RuntimeCall::System(SystemCall::remark { remark: vec![] }); 40_000];
assert_noop!(
Utility::batch(RuntimeOrigin::signed(1), calls.clone()),
Error::<Test>::TooManyCalls
);
assert_noop!(
Utility::batch_all(RuntimeOrigin::signed(1), calls),
Error::<Test>::TooManyCalls
);
});
}
#[test]
fn force_batch_works() {
new_test_ext().execute_with(|| {
assert_eq!(Balances::free_balance(1), 10);
assert_eq!(Balances::free_balance(2), 10);
assert_ok!(Utility::force_batch(
RuntimeOrigin::signed(1),
vec![
call_transfer(2, 5),
call_foobar(true, Weight::from_parts(75, 0), None),
call_transfer(2, 10),
call_transfer(2, 5),
]
));
System::assert_last_event(utility::Event::BatchCompletedWithErrors.into());
System::assert_has_event(
utility::Event::ItemFailed { error: DispatchError::Other("") }.into(),
);
assert_eq!(Balances::free_balance(1), 0);
assert_eq!(Balances::free_balance(2), 20);
assert_ok!(Utility::force_batch(
RuntimeOrigin::signed(2),
vec![call_transfer(1, 5), call_transfer(1, 5),]
));
System::assert_last_event(utility::Event::BatchCompleted.into());
assert_ok!(Utility::force_batch(RuntimeOrigin::signed(1), vec![call_transfer(2, 50),]),);
System::assert_last_event(utility::Event::BatchCompletedWithErrors.into());
});
}
#[test]
fn none_origin_does_not_work() {
new_test_ext().execute_with(|| {
assert_noop!(Utility::force_batch(RuntimeOrigin::none(), vec![]), BadOrigin);
assert_noop!(Utility::batch(RuntimeOrigin::none(), vec![]), BadOrigin);
assert_noop!(Utility::batch_all(RuntimeOrigin::none(), vec![]), BadOrigin);
})
}
#[test]
fn batch_doesnt_work_with_inherents() {
new_test_ext().execute_with(|| {
// fails because inherents expect the origin to be none.
assert_ok!(Utility::batch(
RuntimeOrigin::signed(1),
vec![RuntimeCall::Timestamp(TimestampCall::set { now: 42 }),]
));
System::assert_last_event(
utility::Event::BatchInterrupted {
index: 0,
error: frame_system::Error::<Test>::CallFiltered.into(),
}
.into(),
);
})
}
#[test]
fn force_batch_doesnt_work_with_inherents() {
new_test_ext().execute_with(|| {
// fails because inherents expect the origin to be none.
assert_ok!(Utility::force_batch(
RuntimeOrigin::root(),
vec![RuntimeCall::Timestamp(TimestampCall::set { now: 42 }),]
));
System::assert_last_event(utility::Event::BatchCompletedWithErrors.into());
})
}
#[test]
fn batch_all_doesnt_work_with_inherents() {
new_test_ext().execute_with(|| {
let batch_all = RuntimeCall::Utility(UtilityCall::batch_all {
calls: vec![RuntimeCall::Timestamp(TimestampCall::set { now: 42 })],
});
let info = batch_all.get_dispatch_info();
// fails because inherents expect the origin to be none.
assert_noop!(
batch_all.dispatch(RuntimeOrigin::signed(1)),
DispatchErrorWithPostInfo {
post_info: PostDispatchInfo {
actual_weight: Some(info.weight),
pays_fee: Pays::Yes
},
error: frame_system::Error::<Test>::CallFiltered.into(),
}
);
})
}
#[test]
fn batch_works_with_council_origin() {
new_test_ext().execute_with(|| {
let proposal = RuntimeCall::Utility(UtilityCall::batch {
calls: vec![RuntimeCall::Democracy(mock_democracy::Call::external_propose_majority {})],
});
let proposal_len: u32 = proposal.using_encoded(|p| p.len() as u32);
let proposal_weight = proposal.get_dispatch_info().weight;
let hash = BlakeTwo256::hash_of(&proposal);
assert_ok!(Council::propose(
RuntimeOrigin::signed(1),
3,
Box::new(proposal.clone()),
proposal_len
));
assert_ok!(Council::vote(RuntimeOrigin::signed(1), hash, 0, true));
assert_ok!(Council::vote(RuntimeOrigin::signed(2), hash, 0, true));
assert_ok!(Council::vote(RuntimeOrigin::signed(3), hash, 0, true));
System::set_block_number(4);
assert_ok!(Council::close(
RuntimeOrigin::signed(4),
hash,
0,
proposal_weight,
proposal_len
));
System::assert_last_event(RuntimeEvent::Council(pallet_collective::Event::Executed {
proposal_hash: hash,
result: Ok(()),
}));
})
}
#[test]
fn force_batch_works_with_council_origin() {
new_test_ext().execute_with(|| {
let proposal = RuntimeCall::Utility(UtilityCall::force_batch {
calls: vec![RuntimeCall::Democracy(mock_democracy::Call::external_propose_majority {})],
});
let proposal_len: u32 = proposal.using_encoded(|p| p.len() as u32);
let proposal_weight = proposal.get_dispatch_info().weight;
let hash = BlakeTwo256::hash_of(&proposal);
assert_ok!(Council::propose(
RuntimeOrigin::signed(1),
3,
Box::new(proposal.clone()),
proposal_len
));
assert_ok!(Council::vote(RuntimeOrigin::signed(1), hash, 0, true));
assert_ok!(Council::vote(RuntimeOrigin::signed(2), hash, 0, true));
assert_ok!(Council::vote(RuntimeOrigin::signed(3), hash, 0, true));
System::set_block_number(4);
assert_ok!(Council::close(
RuntimeOrigin::signed(4),
hash,
0,
proposal_weight,
proposal_len
));
System::assert_last_event(RuntimeEvent::Council(pallet_collective::Event::Executed {
proposal_hash: hash,
result: Ok(()),
}));
})
}
#[test]
fn batch_all_works_with_council_origin() {
new_test_ext().execute_with(|| {
assert_ok!(Utility::batch_all(
RuntimeOrigin::from(pallet_collective::RawOrigin::Members(3, 3)),
vec![RuntimeCall::Democracy(mock_democracy::Call::external_propose_majority {})]
));
})
}
#[test]
fn with_weight_works() {
new_test_ext().execute_with(|| {
use frame_system::WeightInfo;
let upgrade_code_call =
Box::new(RuntimeCall::System(frame_system::Call::set_code_without_checks {
code: vec![],
}));
// Weight before is max.
assert_eq!(
upgrade_code_call.get_dispatch_info().weight,
<Test as frame_system::Config>::SystemWeightInfo::set_code()
);
assert_eq!(
upgrade_code_call.get_dispatch_info().class,
frame_support::dispatch::DispatchClass::Operational
);
let with_weight_call = Call::<Test>::with_weight {
call: upgrade_code_call,
weight: Weight::from_parts(123, 456),
};
// Weight after is set by Root.
assert_eq!(with_weight_call.get_dispatch_info().weight, Weight::from_parts(123, 456));
assert_eq!(
with_weight_call.get_dispatch_info().class,
frame_support::dispatch::DispatchClass::Operational
);
})
}