-
Notifications
You must be signed in to change notification settings - Fork 885
functional tests: skip TestSocketProxyd #3049
Conversation
Is this racy also on kvm flavor? kvm flavor is not using nspawn. |
@@ -34,6 +34,10 @@ import ( | |||
) | |||
|
|||
func TestSocketProxyd(t *testing.T) { | |||
// Skip the test for now. See https://github.com/coreos/rkt/issues/1464 for | |||
// details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you link to this too?
#2432 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1464 does not explain the race
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, wrong link.
@krnowak Not sure, as due to nested-virtualization requirement kvm tests are only running on semaphore at the moment. |
This test is currently racy. The socket-activated proxyd service depends on a rkt service being ready. However, the application that runs inside rkt doesn't have a way to signal when it's ready because of rkt#1464. Instead, systemd assumes it's ready when the container starts, which is wrong, because the application inside might not be listening on the port yet. This makes the test fail. It fails a lot particularly in Fedora Rawhide with the flavor host: https://jenkins-rkt-public.prod.coreos.systems/job/rkt-master-periodic/os_type=fedora-rawhide,stage1_flavor=host/ We can re-enable it when we fix rkt#1464.
0eb6fd9
to
01e85a5
Compare
@krnowak it is racy on kvm too because the kvm flavor does not support sdnotify and @alepuccetti's PR #2826 only implements the sdnotify mechanism in the nspawn flavor. It is annoying because the test and documentation about systemd-socket-proxyd was added only for the benefit of the kvm flavor: on the nspawn flavor, users can just use normal socket activation, so they don't need systemd-socket-proxyd. |
#2943 strikes again. |
LGTM |
This test is currently racy. The socket-activated proxyd service depends
on a rkt service being ready. However, the application that runs inside
rkt doesn't have a way to signal when it's ready because of
#1464. Instead, systemd assumes it's
ready when the container starts, which is wrong, because the application
inside might not be listening on the port yet. This makes the test fail.
It fails a lot particularly in Fedora Rawhide with the flavor host:
https://jenkins-rkt-public.prod.coreos.systems/job/rkt-master-periodic/os_type=fedora-rawhide,stage1_flavor=host/
We can re-enable it when we fix #1464.
cc @woodbor