-
Notifications
You must be signed in to change notification settings - Fork 885
TestSocketProxyd is racy #2432
Comments
/cc @woodbor |
It seems to still fail on Fedora 22. Reopening. It is actually installed:
I found the following in journalctl:
|
|
The file
@woodbor what do you mean with a root error of test? |
@woodbor are you able to take a look at this? |
But name of network seems incorrect, I mean: |
@alban could You provide there command line with which rkt was called in this situation? Looks like there was somewhere first |
FYI - removing |
@jellonek well spotted. Removing the |
https://github.com/coreos/rkt/blob/master/Documentation/networking/overriding-defaults.md
This should be reworded: rkt does not expect any double quotes. This assumes that rkt is executed from a shell (like sh or bash) that removes the double quotes before exec()ing. |
Fixes rkt#2432. Command is not sent to a shell, and not remove double quotes by systemd on some old distros (fedora22).
Fixes rkt#2432. Command is not sent to a shell, and not remove double quotes by systemd on some old distros (fedora22).
The command is executed as a systemd unit and is not sent to a shell and the double quotes were not interpreted by systemd-v219 on some old distros (like Fedora 22). Fixes rkt#2432
This seems to happen again on rawhide. |
Hey! And from journalctl on the host: And ptp0.conf file: This problem occurs on kvm and coreos falvors. |
It happened again on Fedora-23: #2860 (comment) |
@alban forgot to reopen |
The failures of the TestSocketProxy test on the fedora rawhide distro are likely because of a race between the echo server and the systemd-socket-proxyd. The latter is set to require the echo server and to start after echo server is ready. But currently nspawn sends the ready notification before inspect binary in the echo server has a chance to run and set up communication channels. So proxy daemon tries to connect to inspect, but inspect didn't start listening so proxyd bails out… To fix we will likely need patches from #2826 merged and implement sending ready notifications in inspect. The test would need to be fixed to make the echo server of "notify" type then. |
I'm disabling the test for now: #3049 |
Also, the documentation at https://github.com/coreos/rkt/blob/master/Documentation/using-rkt-with-systemd.md#bidirectionally-proxy-local-sockets-to-another-possibly-remote-socket will likely need some fixes to reflect what I said above. |
The new test TestSocketProxyd was recently implemented by #2257.
It fails on CentOS 7 and Fedora 22:
I suspect that those distributions have an old systemd version without systemd-proxyd. The test should be skipped when systemd-proxyd is not installed.
The text was updated successfully, but these errors were encountered: