RISC-V Semihosting 3 of 3: Warn if encountered but disabled #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMatCodasip
force-pushed
the
jm-codasip/semihosting-3-warn-if-encountered-but-disabled
branch
from
27cf384 to
aad9f9b
Compare
JanMatCodasip
force-pushed
the
jm-codasip/semihosting-3-warn-if-encountered-but-disabled
branch
3 times, most recently
from
7a1bc94 to
83b9898
Compare
en-sc
reviewed
Jan 15, 2025
JanMatCodasip
force-pushed
the
jm-codasip/semihosting-3-warn-if-encountered-but-disabled
branch
2 times, most recently
from
6ca507b to
1bcd382
Compare
en-sc
previously approved these changes
Jan 20, 2025
JanMatCodasip
dismissed
en-sc’s stale review
The merge-base changed after approval.
If semihosting is disabled but there is a semihosting request encountered in the program, provide a clear hint to the user what happened and what can be done about it. Change-Id: I8fa7b821ca9a853cbc884f38d138fa5c8946c84c Signed-off-by: Jan Matyas <jan.matyas@codasip.com>
JanMatCodasip
force-pushed
the
jm-codasip/semihosting-3-warn-if-encountered-but-disabled
branch
from
1bcd382 to
b7d9ab5
Compare
|
Note: I have rebased this PR after because the dependency #1199 has been merged. |
en-sc
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If semihosting is disabled but there is a semihosting request encountered in the program, provide a clear hint to the user what happened and what can be done about it.