RISC-V Semihosting 2 of 3: Refactor magic sequence detection #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable `target->semihosting` is always initialized in risv_init_target() to a non-NULL value. For that reason, checks like `if (target->semihosting)` are redundant (dead code). Remove them to not confuse code readers. Replace them by assertions. Change-Id: I85ef52300e240cfcb0119db6169993bc4767de8f Signed-off-by: Jan Matyas <jan.matyas@codasip.com>
Refactor (clean up) the code in riscv_semihosting.c by moving the magic sequence detection to its own function. Change-Id: I3a3ce991336ceeeff023d459d0e28558059554e0 Signed-off-by: Jan Matyas <jan.matyas@codasip.com>
JanMatCodasip
changed the title
|
Note: This MR is built on top of #1198. |
Cosmetic, non-functional improvements in `riscv_semihosting_detect_magic_sequence()`. Change-Id: I935d3847749a02e4f579900a0971c30a5cc826b7 Signed-off-by: Jan Matyas <jan.matyas@codasip.com>
aap-sc
requested changes
Jan 10, 2025
| return SEMIHOSTING_NONE; | ||
| } | ||
| if (!sequence_found) { | ||
| LOG_TARGET_DEBUG(target, " -> NONE (no magic)"); |
There was a problem hiding this comment.
maybe move this printout inside riscv_semihosting_detect_magic_sequence?
if (result != ERROR_OK) {
*sequence_found = false;
return result;
}
Having context-dependent printout like this is somewhat confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor (clean up) the code in riscv_semihosting.c by moving
the magic sequence detection to its own function.