Plugins support #21
Plugins support #21
Conversation
| @@ -1,9 +1,11 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -e | |||
There was a problem hiding this comment.
This causes the script to finish early when python /checkdb.py finishes with a non-0 exit code, meaning new installs fail.
I can't figure out whether that's expected, and whether there's missing documentation for bootstrapping, because the PR has no description, documentation, or visible testing. Is there a public ticket? Or is this an error?
There was a problem hiding this comment.
I will have a look on this one, thank you.
There was a problem hiding this comment.
You are right in this point. We actually miss a team and a code review. One person cannot be a developer, self code reviewer and a tester ;)
I introduced the RC versioning, so the testing should be possible easier now, but we miss people 😉
There was a problem hiding this comment.
I resolved the issue in:
b35d22d
Also now to test the clear environment we could do:
make clear startThat would delete all volumes to make sure the application will run from scratch.
The second way of testing should be to stop the environment and make start without clearing anything to see if it gets up second time.
There was a problem hiding this comment.
I'm releasing a 1.0.1 as a hotfix release. Thank you for the report.
…task to make to start a clear environment
…task to make to start a clear environment Adjusted post-install tasks to https://github.com/taigaio/taiga-scripts/blob/master/scripts/setup-backend.sh#L49
No description provided.