-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: If I build the container using the following compose file there seems to be no official Taiga documentation for adding my own contribPlugins
to taiga-frontend.
#7
Comments
We'll have to add support to for adding a list of |
Realistically I’d love to have Trello and github importers but it’s very
unclear thanks to sparse Taiga documentation how to do that.
…On Sun, Aug 25, 2019 at 1:04 PM Zicklag ***@***.***> wrote:
We'll have to add support to for adding a list of contribPlugins to the
conf.json file to this container. That would be a simple change. The
bigger problem is deciding how to allow users of the container to add
plugins. What plugin are you wanting to install? ( So I can look at the
installation instructions )
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AAIE2VQ45ODCI6T6VXNLKJLQGK3QJA5CNFSM4IPJT2LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CXNSI#issuecomment-524646089>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIE2VTB6MMJZTY5H3GVXDDQGK3QJANCNFSM4IPJT2LA>
.
|
Oh, that's super easy. Those importers are actually built-in and just have to be enabled in the config file. We can add environment variables that allow you to enable/disable those importers. |
That would be great! I was just going to build it but if you support it in
the mainline I’m even more happy.
…On Sun, Aug 25, 2019 at 1:59 PM Zicklag ***@***.***> wrote:
Oh, that's super easy. Those importers are actually built-in and just have
to be enabled in the config file. We can add environment variables that
allow you to enable/disable those importers.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AAIE2VRYJD74YQUYDZ5JDVDQGLCAHA5CNFSM4IPJT2LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CYSAQ#issuecomment-524650754>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIE2VR75N7655SRR6QYCCTQGLCAHANCNFSM4IPJT2LA>
.
|
This comment seems to relate to #3 so just mentioning it in this feed for the sake of consistency. |
Could you propose anything @zicklag, I mean some code/PR? I didn't dive into this topic yet. |
I should be able to open a PR soon. |
This is all I could find pointing to contribPlugins in their official documentation for Taiga.io |
Oh, and one other detail, if we're going to have this assert a bunch of things into how Taiga runs we should define an order of precedence so that if someone has modified the configuration in various ways like a volume'd config or something of the sort we should respect that by default. |
Right now, all of the Taiga settings ( at least the Taiga back settings ) that are set by the container are in a Also, most, if not all, of the settings set in When I create the PR for enabling the other importers I'll have them on by default and provide environment variables that allows you to chose which ones to disable/enable. |
This sounds like the kind of behavior that I would hope to expect. I'm kind of miffed that out of all of the best practices that Docker people write they don't discuss the |
Any news on this? 😉 I got a request on the Slack plugin in the Taiga image, I don't know if you have already some progress? 🙂 |
No, I haven't done anything for it. :) If I remember right, the best idea was just to have something like a I don't think Taiga plugins are standardized enough to have a universal plugin install method. |
Hmm... One thing I'm sure - we need to install plugins at build stage -
installing plugins on entrypoint is very, very bad practice that cannot run
on serious production systems.
So the solution would be to install them first, then toggle enable on
entrypoint (using environment variables).
…On Sun, Sep 29, 2019 at 6:01 PM Zicklag ***@***.***> wrote:
No, I haven't done anything for it. :)
If I remember right, the best idea was just to have something like a
pugins.d directory that all of the shell scripts put in that directory
would be run by the entrypoint at startup. That would mean that you could
do whatever kind of setup was necessary to install whatever plugins you
wanted.
I don't think Taiga plugins are standardized enough to have a universal
plugin install method.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AFOAJBWXNPZ45BRTEE5FIEDQMDGPHA5CNFSM4IPJT2LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD73YOXY#issuecomment-536315743>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFOAJBWQYSKMBVRIQXUEVB3QMDGPHANCNFSM4IPJT2LA>
.
|
I agree with that. I wasn't sure if you wanted to be able to install arbitrary plugins at runtime or not, but I would definitely opt for creating derivative images if you need custom plugins. Otherwise, integrating more commonly useful plugins such as LDAP seems like a good idea if somebody has the need for it and doesn't mind contributing. It wasn't hard for me to add LDAP support. I pretty much just followed the installation instructions and added the environment configuration scripts. |
I don't think there are a lot of contrib plugins. We can do an infrastructure for plugins, then on request (when issue will be created) add plugins with acceptance (unstable plugins should not be accepted, as we will have difficulties to maintain the image, and deletion of a non-building plugin later could be a breaking change). |
Ah, and at first we can just add Slack with such method. |
@zicklag Could I assign you to this? |
I'm not sure when I would be able to get to it. I've been a bit busy, but if you wanted to assign it to me I could do it if I do find the time. |
Mark it for #hacktoberfest and they can get the shirt.
…On Wed, Oct 2, 2019 at 2:11 AM Andrew Johnson ***@***.***> wrote:
@zicklag <https://github.com/zicklag> Could I assign you to this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AAIE2VUVFBNXUNCTNSJYGZ3QMQ3RZA5CNFSM4IPJT2LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADVLMQ#issuecomment-537351602>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIE2VTLCR7PKDOEHITYGZDQMQ3RZANCNFSM4IPJT2LA>
.
|
We can be assigned both, haha. So we will see who will start it 😄 |
The main plugin I would love is taiga's trello sync plugin. If we get any more then that's excellent. I don't think this feature add has to be extensive just check if someone has changed a variable from it's default |
The Trello importer is actually already merged. It came with #12. |
Shows how often I'm updating my in-dev containers. I have a constant sprawl of web-apps that I'm testing in my docker-compose micro services cluster. Taiga is one of the ones that've been in my list of todo for ages. |
I would love to see the slack plugin added :). |
ACK :) |
Just for the sake of taking care of anyone who searches up how to do this in the future can we have a proper docker-compose.yml example posted in this thread. Even modifying my example I posted to open the thread. |
subbed! really need the slack contrib :) |
I'm working on it. |
I almost implemented it. The frontend currently does not install properly, it's just a lack of my time - I need to spend an one hour next day to have it finished and tested. I guess, that's my estimation. The plugin system will install everything at build time, and let the devops decide on container startup which plugins to enable. |
Makes sense honestly the inclusion of the plugins probably doesn't really increase the build size that much and if they're really concerned about the containers being that small they should likely be using a different solution. Taiga really doesn't seem lightweight on usage. |
Ok, I'm testing it. I released a first RC. If something would be wrong I would release another RC, when it will be stable I will tag a normal version 1.0 of the container https://github.com/riotkit-org/docker-taiga/releases/tag/1.0-RC1 |
If everything will be ok, then the RC should be on quay as an RC version. |
Damn, actually the CI is blocked because Taiga.io released backend v5.0.0 and frontend v5.0.1 and they didn't release frontend v5.0.0. Assumption that |
It seems that locally I got it working. Trying to make the CI working. I created an additional ticket: |
Hi! Please check new builds on Quay, the plugins support is there. Also all versions are building now. The #23 was resolved. Closing now. Please open a new issue in case that something would not work. Thanks 🙂 |
I invite you to check the recent stable release - |
Any ideas as to how to get contribPlugins working?
The text was updated successfully, but these errors were encountered: