-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a problem where masquerading as esm #210
Fix a problem where masquerading as esm #210
Conversation
Once combined into a single bundle, the default export issue was also fixed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 96.91% 97.30% +0.38%
==========================================
Files 321 321
Lines 56319 57636 +1317
Branches 6587 6807 +220
==========================================
+ Hits 54583 56083 +1500
+ Misses 1724 1541 -183
Partials 12 12 ☔ View full report in Codecov by Sentry. |
Restore bump for debugging
Impressive, nice work! So |
"bundle:deno-prepare": "node ../../config/prepare-denoify.mjs", | ||
"bundle:deno-convert": "denoify --src _deno_prepare/src", | ||
"bundle:deno-move": "rimraf ../../deno_dist/core && mv deno_dist ../../deno_dist/core", | ||
"bundle:deno-clean": "rimraf _deno_prepare", | ||
"bundle:esm": "tsc --p tsconfig.esm.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to keep things clean, I think these json files can be removed too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fixed it.
Thank you. ⭐
Those two are correct. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement!
Related: #191
Fix a problem Masquerading as ESM.
Changed to use tsup to generate
index.d.cts
. Accordingly, Created a tsup config.Operability confirmed
yarn workspace @rimbu/core run build
npm pack
All Submissions:
New Feature Submissions:
Changes to Core Features: