Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customizable export options #510

Merged
merged 7 commits into from
May 16, 2023

Conversation

riccardoperra
Copy link
Owner

@riccardoperra riccardoperra commented Apr 19, 2023

#509

  • Add @codeui/kit Add customizable popover width (e.g. AutoWidth property) or custom class forwarding Added "DynamicSizedContainer" on app core
  • Move segmented field to @codeui/kit to follow right color tokens Will be done later
  • Add ButtonGroup or generic Group support to @codeui/kit (maybe follow approach of https://taiga-ui.dev/components/group#buttons) Not needed anymore

@codesandbox
Copy link

codesandbox bot commented Apr 19, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

🦋 Changeset detected

Latest commit: 7c79062

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@codeimage/app Minor
@codeimage/dom-export Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@riccardoperra riccardoperra changed the base branch from main to next April 19, 2023 18:42
@riccardoperra riccardoperra changed the title Feat/customizable export example feat: customizable export options Apr 19, 2023
@riccardoperra riccardoperra temporarily deployed to Preview April 19, 2023 18:46 — with GitHub Actions Inactive
@riccardoperra riccardoperra temporarily deployed to Preview April 19, 2023 18:46 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Deploy preview for codeimage-website-dev ready!

✅ Preview
https://codeimage-website-5somor226-riccardoperra.vercel.app
https://codeimage-website-pr-510.vercel.app

Built with commit 4447107.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Deploy preview for codeimage ready!

✅ Preview
https://codeimage-cv1phtgkg-riccardoperra.vercel.app
https://codeimage-app-pr-510.vercel.app

Built with commit 7c79062.
This pull request is being automatically deployed with vercel-action

@riccardoperra riccardoperra force-pushed the next branch 2 times, most recently from 6f1b037 to 85f9975 Compare April 27, 2023 21:17
@riccardoperra riccardoperra linked an issue May 13, 2023 that may be closed by this pull request
@riccardoperra riccardoperra force-pushed the feat/customizable-export-example branch from e09ee43 to c4d5ce1 Compare May 13, 2023 08:49
@riccardoperra riccardoperra temporarily deployed to Preview May 13, 2023 08:52 — with GitHub Actions Inactive
@riccardoperra riccardoperra temporarily deployed to Preview May 13, 2023 08:52 — with GitHub Actions Inactive
@riccardoperra riccardoperra temporarily deployed to Preview May 13, 2023 08:52 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2023

Deploy preview for codeimage-highlight-dev ready!

✅ Preview
https://codeimage-highlight-ggl953rbc-riccardoperra.vercel.app
https://codeimage-highlight-pr-510.vercel.app

Built with commit 4447107.
This pull request is being automatically deployed with vercel-action

* add export options persistence
* add export option icon button
* dom-export mime-type support for `getBlob`
@riccardoperra riccardoperra temporarily deployed to Preview May 15, 2023 06:54 — with GitHub Actions Inactive
@riccardoperra riccardoperra temporarily deployed to Preview May 15, 2023 06:54 — with GitHub Actions Inactive
@riccardoperra riccardoperra temporarily deployed to Preview May 15, 2023 06:54 — with GitHub Actions Inactive
* fix dynamic size container autoWidth
* add export settings button on mobile
* remove `fileName` input
@riccardoperra riccardoperra marked this pull request as ready for review May 16, 2023 20:19
@riccardoperra riccardoperra temporarily deployed to Preview May 16, 2023 20:21 — with GitHub Actions Inactive
@riccardoperra riccardoperra temporarily deployed to Preview May 16, 2023 20:21 — with GitHub Actions Inactive
@riccardoperra riccardoperra temporarily deployed to Preview May 16, 2023 20:27 — with GitHub Actions Inactive
@riccardoperra riccardoperra temporarily deployed to Preview May 16, 2023 20:27 — with GitHub Actions Inactive
@riccardoperra riccardoperra temporarily deployed to Preview May 16, 2023 20:27 — with GitHub Actions Inactive
@riccardoperra riccardoperra mentioned this pull request May 16, 2023
37 tasks
@riccardoperra riccardoperra merged commit e38b990 into next May 16, 2023
@riccardoperra riccardoperra deleted the feat/customizable-export-example branch May 16, 2023 20:46
@riccardoperra riccardoperra temporarily deployed to Preview May 16, 2023 20:48 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 - Scale when copy to clipboard
1 participant