Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 - Scale when copy to clipboard #509

Closed
Tracked by #493
goncy opened this issue Apr 19, 2023 · 5 comments · Fixed by #510
Closed
Tracked by #493

🚀 - Scale when copy to clipboard #509

goncy opened this issue Apr 19, 2023 · 5 comments · Fixed by #510
Assignees
Labels
feature New feature or request next Issues or pull request to do in next branch (until 6th May)

Comments

@goncy
Copy link

goncy commented Apr 19, 2023

Which @codeimage/* package(s) are relevant/releated to the feature request?

codeimage

Description

When exporting, you have the ability to scale before saving. But when you copy to the clipboard you only get 1x images that are low-res for slides. Can the resolution of the copied one be increased/configured?

A small hack I found is just override the devicePixelRatio so the image upscales when copied to clipboard:

image

Which works because of this

@goncy goncy added the feature New feature or request label Apr 19, 2023
@riccardoperra
Copy link
Owner

riccardoperra commented Apr 19, 2023

Hi @goncy, this is something I would like to add with priority, and with the ui kit update it's something that may be achieved easily. I was thinking to refactor all of these buttons with a ButtonGroup, and the option to customize the export configuration for each case.

What do you think about it? (screenshots is just an example).

The button option could be available for "Copy to clipboard", "Open" and "Export" action. The configuration may also be shared and persisted locally in order to remember the settings.

Anyway, I can release this feature with the end of April deploy which will contains also the Preset and the new UI update

image

in case you can see the preview here, but options are not working at the moment
https://codeimage-mcs993eup-riccardoperra.vercel.app/

@goncy
Copy link
Author

goncy commented Apr 19, 2023 via email

@riccardoperra riccardoperra self-assigned this Apr 19, 2023
@riccardoperra riccardoperra mentioned this issue Apr 25, 2023
36 tasks
@riccardoperra riccardoperra linked a pull request May 13, 2023 that will close this issue
3 tasks
@riccardoperra riccardoperra moved this from Todo to In Progress in CodeImage May 13, 2023
@riccardoperra
Copy link
Owner

riccardoperra commented May 16, 2023

I haven't forgotten about this but I had so many things to do 😫 This feature should be almost done (just a working preview https://codeimage-31mbaxp2m-riccardoperra.vercel.app).

Both copy-to-clipboard and Open actions will use options from the new export settings button, which will be also persisted locally in order to not lose that settings with refresh

I also added a new scale (6x) that should be enough for most of cases..unless you need images with 10_000x8000 resolution 😅

image

I think I can finish the last few things this week and deploy all the new features in production
#527

@riccardoperra riccardoperra mentioned this issue May 16, 2023
37 tasks
@riccardoperra riccardoperra moved this from In Progress to To Merge in CodeImage May 16, 2023
@riccardoperra riccardoperra moved this from To Merge to Done in CodeImage Jun 4, 2023
@riccardoperra
Copy link
Owner

Done and to be deployed in 1.4.0

@riccardoperra riccardoperra added the next Issues or pull request to do in next branch (until 6th May) label Jun 4, 2023
@riccardoperra
Copy link
Owner

Live with 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request next Issues or pull request to do in next branch (until 6th May)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants