Fixes Expanding Force and Spectral Thief move animations #6185
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
reviewed
Feb 5, 2025
Comment on lines
+2296
to
+2297
| if (gMovesInfo[gCurrentMove].effect == EFFECT_EXPANDING_FORCE && moveTarget & MOVE_TARGET_BOTH) | ||
| gBattleScripting.animTurn = 1; |
There was a problem hiding this comment.
what if only one mon is alive?
|
Expanding force orb should use createspriteontargets and the explosions should use SetAverageBattlerPositions probably. I have fixed it myself but never got around to PRing but would be happy to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Expanding Force not changing its animation when targeting both opponents.
expanding_force.mp4
Fixes Spectral Thief always using the stat stealing animation even if not stealing stat boosts and added that specific animation if successfully stealing stat boosts to be closer to the one used in the games.
spectral_thief.mp4
Feature(s) this PR does NOT handle:
Spectral Thief should steal the target's stat boosts before dealing damage
Discord contact info
PhallenTree