Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CI rules #469

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Update the CI rules #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d567a1b
ci(rubocop): change method and class maximum length
DioFun Jul 9, 2024
9b5d13a
ci(overcommit): add message format warning and remove capitalization
DioFun Jul 9, 2024
beb94b2
style(overcommit): fix excpected_pattern_message content
DioFun Jul 9, 2024
af5c711
ci(overcommit): increase max subject width to 80 chars
DioFun Jul 9, 2024
a3eea96
fix(overcommit): add explicitly enabled to TextWidth rule
DioFun Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .overcommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,22 @@ PreCommit:
# exclude:
# - '**/db/structure.sql' # Ignore trailing whitespace in generated files

CommitMsg:
CapitalizedSubject:
enabled: false

MessageFormat:
enabled: true
description: 'Ensure commit message follows commit style'
on_fail: warn
pattern: '^(build|ci|docs|feat|fix|perf|refactor|style|test)(\(.+\))?: .{1,50}'
expected_pattern_message: '<build|ci|docs|feat|fix|perf|refactor|style|test>(<scope>): <message>'
sample_message: 'ci(rubocop): increase class length limit'

TextWidth:
enabled: true
max_subject_width: 80

PrePush:
Brakeman:
enabled: true
Expand Down
3 changes: 2 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Layout/FirstArrayElementIndentation:

Metrics/ClassLength:
Enabled: true
Max: 200
Exclude:
- test/**/*

Expand All @@ -31,7 +32,7 @@ Minitest/EmptyLineBeforeAssertionMethods:
Enabled: false

Metrics/MethodLength:
Max: 15
Max: 20

Metrics/AbcSize:
Max: 20
Expand Down