Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CI rules #469

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Update the CI rules #469

merged 5 commits into from
Jul 10, 2024

Conversation

DioFun
Copy link
Member

@DioFun DioFun commented Jul 9, 2024

Proposition de mise à jour des règles des différents hooks mais aussi de rubocop :

  • Augmentation de la longueur maximale d'une classe de 100 à 200 lignes
  • Augmentation de la longueur maximale d'une méthode de 15 à 20 lignes
  • Suppression de la majuscule obligatoire en début de commit (bien que non bloquante)
  • Ajout d'un format de message de commit selon le workflow d'AngularJS (non bloquant)
  • Augmentation de la taille maximale du titres des commit de 60 à 80 caractères (non bloquant)

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (01e1374) to head (a3eea96).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #469   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          337       337           
  Branches        35        35           
=========================================
  Hits           337       337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DioFun DioFun requested review from nymous and D0gmaDev July 9, 2024 12:31
D0gmaDev
D0gmaDev previously approved these changes Jul 9, 2024
@DioFun DioFun merged commit f5516c8 into master Jul 10, 2024
7 checks passed
@DioFun DioFun deleted the update_hooks branch July 10, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants