Updates documentation #31
Conversation
This commit adds one big feature and several small fixes. Features: - Adds formatting support Small changes: - Shell was changed from dash to bash - The remark_flags argument was replaced with the often used args argument.
The linting and formatting steps are now seperated such that the formatting output does not get passed to the reviewdog error parser.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Kamil Zabielski <50334623+limakzi@users.noreply.github.com>
…-remark-lint into add_formatting_option
|
@haya14busa, @limakzi Thanks for all the suggestions. Based on your comments, I realized that the error catching behaviour is not needed anymore if we do not add the formatting feature. Therefore, I trimmed down the code, and it is now very close to the original code on the master branch. The features that are now included are: ✨ Features
💥 Breaking changes
I think both features are not really required, but I added them when creating the auto-format feature. We can therefore also remove these features, keep the original implementation (dash shell, without dev args and strict input arg checking) and only keep the updated documentation. Let me know what you think. |
|
🧪 Additional (succesfull) test results can be found rickstaa/action-test-repo#52. |
This commit removes the ability to supply input arguments. This was added for debuggin purposes but is not needed as during debugger we can just export the variables as environmental variables.
This commit fixes some bugs in the Dockerfile and entrypoint files. These bugs were pointed out by handolint on #31.
rickstaa
added
bump:minor
|
🏷️ [bumpr] Next version:v1.1.0 Changes:v1.0.3...reviewdog:add_formatting_option |
|
🏷️ [bumpr] Next version:v2.0.0 Changes:v1.0.3...reviewdog:add_formatting_option |
|
🚀 [bumpr] Bumped! New version:v2.0.0 Changes:v1.0.3...v2.0.0 |
This pull request is a response on #25. In this pull request, I added a format feature to the repository. After a discussion, @haya14busa and I decided that this feature should be in a seperate repository. I, therefore, removed the formatting related changes and kept the rest of the changes. This results in the following features.
✨ Main changes
💥 Breaking changes
black_flagsinput argument toblack_argsas we can also pass non-flag arguments like file paths.