Removes formatting feature #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a discussion with @haya14busa we decided to remove the formatting action again as this should be left inside a seperate repository (see reviewdog/action-remark-lint#25). This repository can be found on https://github.com/rickstaa/action-black.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@haya14busa What do you think should I add a minor or major version change label for this? |
haya14busa
requested changes
Jan 8, 2021
Maybe we can bump major version because it's breaking change. |
tsuyoshicho
approved these changes
Jan 8, 2021
rickstaa
force-pushed
the
remove_formatting_feature
branch
from
9d64a30 to
94e0d79
Compare
|
🧪 Additional (successful) test results can be found rickstaa/action-test-repo#51. |
rickstaa
commented
Jan 8, 2021
haya14busa
approved these changes
Jan 10, 2021
|
alex disable specifc word
Add to entrypoint.sh for clearing check. |
This commit changes the `black_flags` input argument to `black_args` as this better describes what it does. Additionally it contains some small bug fixes.
|
🏷️ [bumpr] Next version:v2.0.0 Changes:v1.4.0...reviewdog:remove_formatting_feature |
|
🚀 [bumpr] Bumped! New version:v2.0.0 Changes:v1.4.0...v2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion with @haya14busa we decided to remove the formatting action again as this should be left inside a seperate repository (see reviewdog/action-remark-lint#25). This repository can be found on https://github.com/rickstaa/action-black.