Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor restatectl improvements #2668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muhamadazmy
Copy link
Contributor

@muhamadazmy muhamadazmy commented Feb 7, 2025

Minor restatectl improvements

This fixes the logs list view and shows the configuration in a proper way

Log Configuration (v3)
Default Provider Config:
 └ Logs Provider: replicated
   ├ Log replication: {node: 2}
   └ Nodeset size: 0
 L-ID  FROM-LSN  KIND        LOGLET-ID  REPLICATION  SEQUENCER  NODESET
 0     2         Replicated  0_1        {node: 2}    N1:2       [N1, N2, N3]
 1     1         Replicated  1_1        {node: 2}    N3:1       [N1, N2, N3]
 2     2         Replicated  2_1        {node: 2}    N1:2       [N1, N2, N3]
 3     1         Replicated  3_1        {node: 2}    N3:1       [N1, N2, N3]

instead of

Log Configuration (v3)
Default Provider Config: Replicated(ReplicatedLogletConfig { replication_property: {node: 2}, target_nodeset_size: NodeSetSize(0) })
 L-ID  FROM-LSN  KIND        LOGLET-ID  REPLICATION  SEQUENCER  NODESET
 0     2         Replicated  0_1        {node: 2}    N1:2       [N1, N2, N3]
 1     1         Replicated  1_1        {node: 2}    N3:1       [N1, N2, N3]
 2     2         Replicated  2_1        {node: 2}    N1:2       [N1, N2, N3]
 3     1         Replicated  3_1        {node: 2}    N3:1       [N1, N2, N3]

@muhamadazmy muhamadazmy marked this pull request as ready for review February 7, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant