Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize imports #2662

Closed

Conversation

pcholakov
Copy link
Contributor

@pcholakov pcholakov commented Feb 7, 2025

Shifts the first trim check to happen at the configured trim check interval plus a small jitter factor, to avoid warnings on cluster startup.
@pcholakov pcholakov requested a review from muhamadazmy February 7, 2025 10:36
Copy link
Contributor

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcholakov for this PR. LGTM, +1 for merging. I only left one question

crates/admin/src/cluster_controller/service/state.rs Outdated Show resolved Hide resolved
@muhamadazmy muhamadazmy changed the title Avoid doing a trim first thing on startup Reorganize imports Feb 7, 2025
@muhamadazmy muhamadazmy closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants