DPI to DPR #1277
Merged
DPI to DPR #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojVivek
reviewed
Aug 7, 2024
|
@all-contributors Please add @wp043 for code. |
|
I've put up a pull request to add @wp043! 🎉 |
|
@all-contributors Please add @wp043 for code. Adding again as the other PR was in merge conflict. |
|
@wp043 already contributed before to code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
Fixes #1257
ℹ️ About the PR
According to the bug report, changed the field DPI in the custom device list to DPR. Also allows floating number by parseFloat instead of parseInt and I've changed the step of the DPR to 0.1 instead of the default 1 to allow users adjust the DPR more easily.
🖼️ Testing Scenarios / Screenshots