Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Device DPI" is actually Device Pixel Ratio (DPR) and should allow decimals #1257

Closed
kkmuffme opened this issue Jul 1, 2024 · 1 comment · Fixed by #1277
Closed

"Device DPI" is actually Device Pixel Ratio (DPR) and should allow decimals #1257

kkmuffme opened this issue Jul 1, 2024 · 1 comment · Fixed by #1277

Comments

@kkmuffme
Copy link

kkmuffme commented Jul 1, 2024

🐞 bug report

✍️ Description

"Device Manager" - the "Device DPI" isn't actually "DPI" but "DPR" (Device Pixel Ratio)
How I know? The values used in the presets (1 and 2) would mean a screen is unusable since the resolution is so low. Common values for DPI are much higher, in the 70+ range.
Please rename this.

Additionally, it should allow decimals, since a DPR of 1.5 is rather common too and often behaves differently than 2.

🕵🏼‍♂️ Is this a regression?

No

🌍 Your Environment

1.12.0
@wp043
Copy link
Contributor

wp043 commented Aug 7, 2024 •
edited
Loading

I want to work on this

@wp043 wp043 mentioned this issue Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DPI to DPR wp043/responsively-app
2 participants
@kkmuffme @wp043