Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose basic information about group of pictures in video data in the selection panel #8043

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Expose basic information about group of pictures in video data in the selection panel #8043

merged 3 commits into from
Nov 8, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 7, 2024 •
edited by github-actions bot
Loading

What

Added some more information to the selection panel while investigating #7956
Part of the hidden-by-default sections since this goes fairly deep and is full of scary TLAs.

my favorite h264 sample:
image

av1 sample:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk self-requested a review November 8, 2024 08:30
emilk
emilk approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

crates/viewer/re_data_ui/src/video.rs Show resolved Hide resolved
crates/viewer/re_renderer/src/video/player.rs Show resolved Hide resolved
crates/viewer/re_renderer/src/video/player.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf added the do-not-merge Do not merge this PR label Nov 8, 2024
Base automatically changed from andreas/fix-video-timestamp-offset to main November 8, 2024 10:19
@Wumpf Wumpf force-pushed the andreas/expose-gop-information branch from b4be457 to 6864c0b Compare November 8, 2024 14:39
@Wumpf Wumpf force-pushed the andreas/expose-gop-information branch 2 times, most recently from 2fc81cd to 456265a Compare November 8, 2024 14:42
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Nov 8, 2024
@Wumpf Wumpf merged commit 119b55f into main Nov 8, 2024
37 of 38 checks passed
@Wumpf Wumpf deleted the andreas/expose-gop-information branch November 8, 2024 15:40
@talmo talmo mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
include in changelog 📺 re_viewer affects re_viewer itself 🎞️ video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @emilk