Stepping back doesn't always enqueue frames to the decoder (in the presence of b-frames?) #7956
Comments
6 tasks
Wumpf
added a commit
that referenced
this issue
Nov 8, 2024
… selection panel (#8043) ### What Added some more information to the selection panel while investigating #7956 Part of the hidden-by-default sections since this goes fairly deep and is full of scary TLAs. my favorite h264 sample: <img width="303" alt="image" src="https://github.com/user-attachments/assets/2b3faa39-e728-4b4f-8428-d32a87d270ab"> av1 sample: <img width="297" alt="image" src="https://github.com/user-attachments/assets/eaa9828e-edb5-4bd3-a066-5a7842b5d0d1"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8043?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8043?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/8043) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When stepping back frame by frame we sometimes don't seem to feed the decoder (our current strategy requires restarting the decoder for every step back).
This likely happens only on bframes where we then incorrectly assume that all the samples were already fed into the decoder (this is an educated guess, the lack of feeding I checked empirically). This was observed both with the upcoming ffmpeg decoder and
Repro'ed reliably with this video
bunny_timestamped_h264_1080p_10s.mp4
on Chrome & native.
(due to #7961 I can't observe this in other browsers)
The text was updated successfully, but these errors were encountered: