Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow showing the same videos at several timestamps at the same time #7473

Merged
merged 8 commits into from
Sep 23, 2024
Merged

Allow showing the same videos at several timestamps at the same time #7473

merged 8 commits into from
Sep 23, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 23, 2024 •
edited by github-actions bot
Loading

What

https://github.com/user-attachments/assets/5f0a1f76-fd56-4f80-87f9-c3e02cd6e8d2
Decoders are now lazily created. There can now be several per video, each identified by a user provided identifier.
If decoders are not used for a frame, they get automatically destroyed.

Also fixes flickering issue when switching from an video error state to pending - now whenever we enter the pending state after an error, we clear out the target texture first.

Commit-by-commit review enabled.

example screenshot

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Sep 23, 2024
@Wumpf Wumpf requested a review from jprochazk September 23, 2024 13:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Deployed docs

Commit Link
afca1d7 https://landing-fyyta8htp-rerun.vercel.app/docs

emilk
emilk approved these changes Sep 23, 2024
View reviewed changes
tests/assets/download_test_assets.py Outdated Show resolved Hide resolved
docs/snippets/all/archetypes/video_manual_frames.rs Outdated Show resolved Hide resolved
crates/viewer/re_viewer_context/src/cache/caches.rs Show resolved Hide resolved
crates/viewer/re_viewer_context/src/cache/caches.rs Show resolved Hide resolved
crates/viewer/re_renderer/src/video/mod.rs Outdated Show resolved Hide resolved
jprochazk
jprochazk approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@jprochazk jprochazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Wumpf Wumpf added do-not-merge Do not merge this PR and removed do-not-merge Do not merge this PR labels Sep 23, 2024
@Wumpf Wumpf merged commit bbf7d95 into main Sep 23, 2024
40 of 42 checks passed
@Wumpf Wumpf deleted the andreas/sample-multivideo branch September 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprochazk jprochazk jprochazk approved these changes

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't show the same video in multiple space views
3 participants
@Wumpf @emilk @jprochazk