better entity names

rerun-io · Sep 23, 2024 · afca1d7 · afca1d7
1 parent 8b2e9a8
commit afca1d7
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 45 deletions.
diff --git a/crates/store/re_types/src/archetypes/asset_video.rs b/crates/store/re_types/src/archetypes/asset_video.rs
diff --git a/crates/store/re_types/src/archetypes/video_frame_reference.rs b/crates/store/re_types/src/archetypes/video_frame_reference.rs
diff --git a/docs/snippets/all/archetypes/video_manual_frames.cpp b/docs/snippets/all/archetypes/video_manual_frames.cpp
@@ -23,14 +23,8 @@ int main(int argc, char* argv[]) {
     rec.log_static("video_asset", rerun::AssetVideo::from_file(path).value_or_throw());
 
     // Create two entities, showing the same video frozen at different times.
-    rec.log(
-        "frame_at_one_second",
-        rerun::VideoFrameReference(1.0s).with_video_reference("video_asset")
-    );
-    rec.log(
-        "frame_at_two_second",
-        rerun::VideoFrameReference(2.0s).with_video_reference("video_asset")
-    );
+    rec.log("frame_1s", rerun::VideoFrameReference(1.0s).with_video_reference("video_asset"));
+    rec.log("frame_2s", rerun::VideoFrameReference(2.0s).with_video_reference("video_asset"));
 
     // TODO(#5520): log blueprint once supported
 }
diff --git a/docs/snippets/all/archetypes/video_manual_frames.py b/docs/snippets/all/archetypes/video_manual_frames.py
@@ -18,21 +18,19 @@
 
 # Create two entities, showing the same video frozen at different times.
 rr.log(
-    "frame_at_one_second",
+    "frame_1s",
     rr.VideoFrameReference(
         timestamp=rr.components.VideoTimestamp(seconds=1.0),
         video_reference="video_asset",
     ),
 )
 rr.log(
-    "frame_at_two_second",
+    "frame_2s",
     rr.VideoFrameReference(
         timestamp=rr.components.VideoTimestamp(seconds=2.0),
         video_reference="video_asset",
     ),
 )
 
 # Send blueprint that shows two 2D views next to each other.
-rr.send_blueprint(
-    rrb.Horizontal(rrb.Spatial2DView(origin="frame_at_one_second"), rrb.Spatial2DView(origin="frame_at_two_second"))
-)
+rr.send_blueprint(rrb.Horizontal(rrb.Spatial2DView(origin="frame_1s"), rrb.Spatial2DView(origin="frame_2s")))
diff --git a/docs/snippets/all/archetypes/video_manual_frames.rs b/docs/snippets/all/archetypes/video_manual_frames.rs
@@ -18,12 +18,12 @@ fn main() -> anyhow::Result<()> {
 
     // Create two entities, showing the same video frozen at different times.
     rec.log(
-        "frame_at_one_second",
+        "frame_1s",
         &rerun::VideoFrameReference::new(rerun::components::VideoTimestamp::from_seconds(1.0))
             .with_video_reference("video_asset"),
     )?;
     rec.log(
-        "frame_at_two_second",
+        "frame_2s",
         &rerun::VideoFrameReference::new(rerun::components::VideoTimestamp::from_seconds(2.0))
             .with_video_reference("video_asset"),
     )?;

diff --git a/rerun_cpp/src/rerun/archetypes/asset_video.hpp b/rerun_cpp/src/rerun/archetypes/asset_video.hpp
diff --git a/rerun_cpp/src/rerun/archetypes/video_frame_reference.hpp b/rerun_cpp/src/rerun/archetypes/video_frame_reference.hpp
diff --git a/rerun_py/rerun_sdk/rerun/archetypes/asset_video.py b/rerun_py/rerun_sdk/rerun/archetypes/asset_video.py
diff --git a/rerun_py/rerun_sdk/rerun/archetypes/video_frame_reference.py b/rerun_py/rerun_sdk/rerun/archetypes/video_frame_reference.py