-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make default notebook widget size smaller and configurable #6827
Conversation
not sure if that's what we want? The original ticket called for hyper intelligent (😉) sizing where we do stuff like detecting that an incoming image has a certain size. |
I misunderstood. This is just the first part of the issue, then. It's a better default size because it's smaller, taking up less vertical space, and with a 6.4 / 4.8 aspect ratio. The original issue asked for 6.4 x 4.8 inches, but I don't think we actually want to use inches as a unit, even though it's possible. We can dynamically size the viewer as well, by updating its style. We can do that at any level (in viewer, in web-viewer JS, in widget JS, in |
It could be nice if the defaults were something the user could set once as a global instead of needing to override on every call you notebook_show. |
What would that look like? I don't know what would be idiomatic in Python, at least the following would be possible: # top-level function
from rerun.notebook import set_default_size
set_default_size(width=640, height=480) # static method
from rerun.notebook import Viewer
Viewer.set_default_size(width=640, height=480) # "static" property
from rerun.notebook import Viewer
Viewer.size = (640, 840) |
@abey79 do you have any thoughts on this? I find the top-level function design:
to be the most straight-forward to think about. |
Agreed. |
Alright, I added |
What
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.