Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better default window size when running in notebooks #2289

Open
nikolausWest opened this issue May 31, 2023 · 4 comments
Open

Better default window size when running in notebooks #2289

nikolausWest opened this issue May 31, 2023 · 4 comments
Labels
😤 annoying Something in the UI / SDK is annoying to use 🟦 blueprint The data that defines our UI

Comments

@nikolausWest
Copy link
Member

When displaying Rerun in a notebook, the default window size is way too big. We should use a smaller size by default. Pyplot uses a default figsize default: 6.4 x 4.8 inches so I suggest we go with that for starters.

Related (perhaps should be a different issue):
Would be great if the window could be sized to fit the data (when that makes sense) so that we don't show unnecessary "dead" areas
Screenshot 2023-05-31 at 14 56 15

@nikolausWest nikolausWest added 😤 annoying Something in the UI / SDK is annoying to use 🟦 blueprint The data that defines our UI labels May 31, 2023
@jleibs
Copy link
Member

jleibs commented Jun 1, 2023

The window size only feels big with side-panels hidden. If we show selection/blueprint we need all the space we can get.

Regarding resizing the iFrame to fit the data, it would be nice but will definitely require some thought to get right. For example, we probably only want to resize once to avoid bad cycles of the new size causing the layout to change, in turn, asking for a different size. But also it’s not clear what update pass we want to use to do the calculation since different time points/timelines/app-states will all want different heights.

@nikolausWest
Copy link
Member Author

nikolausWest commented Jun 1, 2023

If we show selection/blueprint we need all the space we can get.

Thus:

@Wumpf
Copy link
Member

Wumpf commented Jul 9, 2024

@jprochazk @jleibs now that you come back fresh from notebook land: Is it realistic for us to do this in the future or are the controls we have for dynamically sizing the widget too limited?

@jprochazk
Copy link
Member

jprochazk commented Jul 9, 2024

There's no restriction to how we can size the widget. We just need to update DEFAULT_WIDTH and DEFAULT_HEIGHT in notebook.py:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🟦 blueprint The data that defines our UI
Projects
None yet
Development

No branches or pull requests

4 participants