This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 70
Run kustomize with base resources #727
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ed3ff94
add initial kustomize run to preexecute func
Rob0h 621dda9
add unit tests for replacing original file
Rob0h 1fb11d1
update a lot of the init integration test yaml
Rob0h 8167665
move splitting multi doc yaml to kustomize
Rob0h 1183506
fix update integration
Rob0h 8d6dada
fix crds
Rob0h File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
integration/init/cockroach/expected/base/ClusterRoleBinding-cockroachdb.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
apiVersion: rbac.authorization.k8s.io/v1beta1 | ||
kind: ClusterRoleBinding | ||
metadata: | ||
name: cockroachdb | ||
labels: | ||
app: cockroachdb | ||
name: cockroachdb | ||
roleRef: | ||
apiGroup: rbac.authorization.k8s.io | ||
kind: ClusterRole | ||
name: cockroachdb | ||
subjects: | ||
- kind: ServiceAccount | ||
name: cockroachdb | ||
namespace: default | ||
namespace: default |
4 changes: 2 additions & 2 deletions
4
integration/init/cockroach/expected/base/PodDisruptionBudget-cockroachdb-budget.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
apiVersion: policy/v1beta1 | ||
kind: PodDisruptionBudget | ||
metadata: | ||
name: cockroachdb-budget | ||
labels: | ||
app: cockroachdb | ||
name: cockroachdb-budget | ||
spec: | ||
maxUnavailable: 1 | ||
selector: | ||
matchLabels: | ||
app: cockroachdb | ||
maxUnavailable: 1 |
4 changes: 2 additions & 2 deletions
4
integration/init/cockroach/expected/base/Role-cockroachdb.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
apiVersion: rbac.authorization.k8s.io/v1beta1 | ||
kind: Role | ||
metadata: | ||
name: cockroachdb | ||
labels: | ||
app: cockroachdb | ||
name: cockroachdb | ||
rules: | ||
- apiGroups: | ||
- "" | ||
resources: | ||
- secrets | ||
verbs: | ||
- create | ||
- get | ||
- get |
4 changes: 2 additions & 2 deletions
4
integration/init/cockroach/expected/base/RoleBinding-cockroachdb.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
apiVersion: rbac.authorization.k8s.io/v1beta1 | ||
kind: RoleBinding | ||
metadata: | ||
name: cockroachdb | ||
labels: | ||
app: cockroachdb | ||
name: cockroachdb | ||
roleRef: | ||
apiGroup: rbac.authorization.k8s.io | ||
kind: Role | ||
name: cockroachdb | ||
subjects: | ||
- kind: ServiceAccount | ||
name: cockroachdb | ||
namespace: default | ||
namespace: default |
17 changes: 6 additions & 11 deletions
17
integration/init/cockroach/expected/base/Service-cockroachdb-public.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,16 @@ | ||
apiVersion: v1 | ||
kind: Service | ||
metadata: | ||
# This service is meant to be used by clients of the database. It exposes a ClusterIP that will | ||
# automatically load balance connections to the different database pods. | ||
name: cockroachdb-public | ||
labels: | ||
app: cockroachdb | ||
name: cockroachdb-public | ||
spec: | ||
ports: | ||
# The main port, served by gRPC, serves Postgres-flavor SQL, internode | ||
# traffic and the cli. | ||
- port: 26257 | ||
- name: grpc | ||
port: 26257 | ||
targetPort: 26257 | ||
name: grpc | ||
# The secondary port serves the UI as well as health and debug endpoints. | ||
- port: 8080 | ||
- name: http | ||
port: 8080 | ||
targetPort: 8080 | ||
name: http | ||
selector: | ||
app: cockroachdb | ||
app: cockroachdb | ||
35 changes: 12 additions & 23 deletions
35
integration/init/cockroach/expected/base/Service-cockroachdb.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,22 @@ | ||
apiVersion: v1 | ||
kind: Service | ||
metadata: | ||
# This service only exists to create DNS entries for each pod in the stateful | ||
# set such that they can resolve each other's IP addresses. It does not | ||
# create a load-balanced ClusterIP and should not be used directly by clients | ||
# in most circumstances. | ||
name: cockroachdb | ||
labels: | ||
app: cockroachdb | ||
annotations: | ||
# This is needed to make the peer-finder work properly and to help avoid | ||
# edge cases where instance 0 comes up after losing its data and needs to | ||
# decide whether it should create a new cluster or try to join an existing | ||
# one. If it creates a new cluster when it should have joined an existing | ||
# one, we'd end up with two separate clusters listening at the same service | ||
# endpoint, which would be very bad. | ||
service.alpha.kubernetes.io/tolerate-unready-endpoints: "true" | ||
# Enable automatic monitoring of all instances when Prometheus is running in the cluster. | ||
prometheus.io/scrape: "true" | ||
prometheus.io/path: "_status/vars" | ||
prometheus.io/path: _status/vars | ||
prometheus.io/port: "8080" | ||
prometheus.io/scrape: "true" | ||
service.alpha.kubernetes.io/tolerate-unready-endpoints: "true" | ||
labels: | ||
app: cockroachdb | ||
name: cockroachdb | ||
spec: | ||
clusterIP: None | ||
ports: | ||
- port: 26257 | ||
- name: grpc | ||
port: 26257 | ||
targetPort: 26257 | ||
name: grpc | ||
- port: 8080 | ||
- name: http | ||
port: 8080 | ||
targetPort: 8080 | ||
name: http | ||
clusterIP: None | ||
selector: | ||
app: cockroachdb | ||
app: cockroachdb |
4 changes: 2 additions & 2 deletions
4
integration/init/cockroach/expected/base/ServiceAccount-cockroachdb.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
apiVersion: v1 | ||
kind: ServiceAccount | ||
metadata: | ||
name: cockroachdb | ||
labels: | ||
app: cockroachdb | ||
app: cockroachdb | ||
name: cockroachdb |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like how we're losing comments here
I suppose there's nothing for it though
Unless it's possible to use Ethan's comment preservation code... But I really highly doubt it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might actually - i'll give it a gothe yaml contents get replaced by the output from kustomize so you're right it's not possible to change heh