This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Run kustomize with base resources #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
reviewed
Nov 27, 2018
| app: cockroachdb |
There was a problem hiding this comment.
I don't really like how we're losing comments here
I suppose there's nothing for it though
Unless it's possible to use Ethan's comment preservation code... But I really highly doubt it
There was a problem hiding this comment.
it might actually - i'll give it a go the yaml contents get replaced by the output from kustomize so you're right it's not possible to change heh
laverya
reviewed
Nov 27, 2018
| return nil | ||
| } | ||
|
|
||
| func (l *Kustomizer) replaceOriginal(step api.Kustomize, built []postKustomizeFile) error { |
There was a problem hiding this comment.
I would love a test for this
It looks like it should work fine with our mocked FS for testing, right?
There was a problem hiding this comment.
Which exists already, and I completely missed. Right.
laverya
approved these changes
Nov 27, 2018
|
(Also, none of the integration tests have a rendered.yaml change, so that's good) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
How I Did it
How to verify it
ship initand check the diff in the UIDescription for the Changelog
Picture of a Boat (not required but encouraged)
🚢