Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-devtools-inline to 4.18.0 to fix node_modules size #7953

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

markerikson
Copy link
Collaborator

@markerikson markerikson commented Oct 12, 2022

Ref: facebook/react#22220

4.17.0 was a known bad release with an unzipped size of 400MB+. 4.18 only has a couple changes, and it's still before the React DevTools "protocol bridge" version changed in 4.22.0:

So, bumping this to use 4.18 as our "old protocol bridge version" package should still be safe, and shrink the install size we need locally.

@vercel
Copy link

vercel bot commented Oct 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
devtools ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 8:54PM (UTC)

@replay-io
Copy link

replay-io bot commented Oct 12, 2022

48 replays were recorded for cd05d2e.

image 3 Failed
image 45 Passed

View test run on Replay ↗︎

@markerikson markerikson merged commit d0ed4de into main Oct 12, 2022
@markerikson markerikson deleted the bugfix/FE-834-react-devtools branch October 12, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant