Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-devtools-inline@4.17.0 weighs over 400MB (!!!) #22220

Closed
AviVahl opened this issue Aug 31, 2021 · 5 comments
Closed

react-devtools-inline@4.17.0 weighs over 400MB (!!!) #22220

AviVahl opened this issue Aug 31, 2021 · 5 comments
Assignees
@lunaruan
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@AviVahl
Copy link

AviVahl commented Aug 31, 2021 •
edited
Loading

@bvaughn I think it was published by you. I see paths such as /Users/bvaughn/Documents/git/react.devtools in the bundle's comments.

v4.16.0 weighs under 8MB.
v4.17.0 weighs over 400MB and contains many dev-time bundles with source maps.

See https://www.npmjs.com/package/react-devtools-inline ("Unpacked Size: 426MB")
Or install locally to reproduce.
@AviVahl AviVahl added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Aug 31, 2021
@bvaughn
Copy link
Contributor

bvaughn commented Aug 31, 2021

This is likely related to the named hooks feature, which imports @babel/parser. I thought this code only made its way into the browser extensions, but apparently it leaked.

We're looking to clean this up, regardless. Thanks for the info though. We'll be sure to look at the inline package as well.

@lunaruan lunaruan self-assigned this Sep 1, 2021
@lunaruan lunaruan mentioned this issue Sep 1, 2021
Merged
@bvaughn
Copy link
Contributor

bvaughn commented Sep 1, 2021 •
edited by lunaruan
Loading

This will be fixed by #22232 and #22234

@AviVahl
Copy link
Author

AviVahl commented Sep 1, 2021

Thanks! I'll wait for the release 👍

@bvaughn
Copy link
Contributor

bvaughn commented Sep 1, 2021

It's being published today, see #22234 😄

@bvaughn bvaughn closed this as completed Sep 1, 2021
@AviVahl
Copy link
Author

AviVahl commented Sep 2, 2021

v4.18.0 verified as fixed from my end. Thank you for addressing this.

markerikson added a commit to replayio/devtools that referenced this issue Oct 12, 2022
@markerikson
Update react-devtools-inline to 4.18.0 to fix node_modules size
cd05d2e 
Ref: facebook/react#22220
@markerikson markerikson mentioned this issue Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lunaruan lunaruan

Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bvaughn @lunaruan @AviVahl @eps1lon