feat(deps): upgrade to got v10

.eslintrc.js

@@ -6,6 +6,10 @@ module.exports = {
   extends: [
     'airbnb-typescript/base',
     // https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin/src/configs
+
+    'plugin:import/errors',
+    'plugin:import/warnings',
+    'plugin:import/typescript',
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
     'plugin:@typescript-eslint/recommended-requiring-type-checking',
@@ -56,6 +60,10 @@ module.exports = {
       },
     ], // disable until proper interfaced api
   },
+  settings: {
+    // https://github.com/benmosher/eslint-plugin-import/issues/1618
+    'import/internal-regex': '^type\\-fest$',
+  },
   overrides: [
     {
       files: ['**/*.spec.ts'],

lib/config/presets/github.ts

@@ -11,8 +11,8 @@ async function fetchJSONFile(repo: string, fileName: string): Promise<Preset> {
         ? 'application/vnd.github.machine-man-preview+json'
         : 'application/vnd.github.v3+json',
     },
-    json: true,
-    hostType: 'github',
+    responseType: 'json',
+    context: { hostType: 'github' },
   };
   let res: { body: { content: string } };
   try {

lib/datasource/cdnjs/index.ts

@@ -36,7 +36,7 @@ export async function getDigest(
   const assetName = lookupName.replace(`${library}/`, '');
   let res = null;
   try {
-    res = await got(url, { hostType: id, json: true });
+    res = await got(url, { context: { hostType: id }, responseType: 'json' });
   } catch (e) /* istanbul ignore next */ {
     return null;
   }
@@ -70,7 +70,10 @@ export async function getPkgReleases({
   const url = depUrl(library);
 
   try {
-    const res = await got(url, { hostType: id, json: true });
+    const res = await got(url, {
+      context: { hostType: id },
+      responseType: 'json',
+    });
 
     const cdnjsResp: CdnjsResponse = res.body;
 

lib/datasource/crate/index.ts

@@ -46,7 +46,7 @@ export async function getPkgReleases({
   const crateUrl = baseUrl + path;
   try {
     let res: any = await got(crateUrl, {
-      hostType: id,
+      context: { hostType: id },
     });
     if (!res || !res.body) {
       logger.warn(

lib/datasource/dart/index.ts

@@ -23,8 +23,8 @@ export async function getPkgReleases({
   } = null;
   try {
     raw = await got(pkgUrl, {
-      hostType: id,
-      json: true,
+      responseType: 'json',
+      context: { hostType: id },
     });
   } catch (err) {
     if (err.statusCode === 404 || err.code === 'ENOTFOUND') {

lib/datasource/docker/__snapshots__/index.spec.ts.snap

@@ -15,7 +15,7 @@ exports[`api/docker getPkgReleases adds library/ prefix for Docker Hub (explicit
         "headers": Object {
           "authorization": "Basic c29tZS11c2VybmFtZTpzb21lLXBhc3N3b3Jk",
         },
-        "json": true,
+        "responseType": "json",
       },
     ],
     Array [
@@ -24,7 +24,7 @@ exports[`api/docker getPkgReleases adds library/ prefix for Docker Hub (explicit
         "headers": Object {
           "authorization": "Bearer some-token ",
         },
-        "json": true,
+        "responseType": "json",
       },
     ],
     Array [
@@ -103,7 +103,7 @@ exports[`api/docker getPkgReleases adds library/ prefix for Docker Hub (implicit
         "headers": Object {
           "authorization": "Basic c29tZS11c2VybmFtZTpzb21lLXBhc3N3b3Jk",
         },
-        "json": true,
+        "responseType": "json",
       },
     ],
     Array [
@@ -112,7 +112,7 @@ exports[`api/docker getPkgReleases adds library/ prefix for Docker Hub (implicit
         "headers": Object {
           "authorization": "Bearer some-token ",
         },
-        "json": true,
+        "responseType": "json",
       },
     ],
     Array [
@@ -191,7 +191,7 @@ exports[`api/docker getPkgReleases adds no library/ prefix for other registries
         "headers": Object {
           "authorization": "Basic c29tZS11c2VybmFtZTpzb21lLXBhc3N3b3Jk",
         },
-        "json": true,
+        "responseType": "json",
       },
     ],
     Array [
@@ -200,7 +200,7 @@ exports[`api/docker getPkgReleases adds no library/ prefix for other registries
         "headers": Object {
           "authorization": "Bearer some-token ",
         },
-        "json": true,
+        "responseType": "json",
       },
     ],
     Array [
@@ -277,7 +277,7 @@ exports[`api/docker getPkgReleases uses custom registry in depName 1`] = `
       "https://registry.company.com/v2/node/tags/list?n=10000",
       Object {
         "headers": Object {},
-        "json": true,
+        "responseType": "json",
       },
     ],
     Array [
@@ -325,14 +325,14 @@ Array [
     "https://registry.company.com/v2/node/tags/list?n=10000",
     Object {
       "headers": Object {},
-      "json": true,
+      "responseType": "json",
     },
   ],
   Array [
     "https://api.github.com/user/9287/repos?page=3&per_page=100",
     Object {
       "headers": Object {},
-      "json": true,
+      "responseType": "json",
     },
   ],
   Array [
@@ -365,7 +365,7 @@ exports[`api/docker getPkgReleases uses lower tag limit for ECR deps 1`] = `
       "https://123456789.dkr.ecr.us-east-1.amazonaws.com/v2/node/tags/list?n=1000",
       Object {
         "headers": Object {},
-        "json": true,
+        "responseType": "json",
       },
     ],
     Array [

lib/datasource/docker/index.ts

@@ -3,12 +3,12 @@ import hasha from 'hasha';
 import URL from 'url';
 import parseLinkHeader from 'parse-link-header';
 import wwwAuthenticate from 'www-authenticate';
-import { OutgoingHttpHeaders } from 'http';
 import AWS from 'aws-sdk';
+import { Options } from 'got';
 import { logger } from '../../logger';
-import got from '../../util/got';
+import got, { GotHeaders, RenovateGotNormalizedOptions } from '../../util/got';
 import * as hostRules from '../../util/host-rules';
-import { DatasourceError, GetReleasesConfig, ReleaseResult } from '../common';
+import { DatasourceError, PkgReleaseConfig, ReleaseResult } from '../common';
 import { GotResponse } from '../../platform';
 
 // TODO: add got typings when available
@@ -58,7 +58,7 @@ export function getRegistryRepository(
 
 function getECRAuthToken(
   region: string,
-  opts: hostRules.HostRule
+  opts: Options
 ): Promise<string | null> {
   const config = { region, accessKeyId: undefined, secretAccessKey: undefined };
   if (opts.username && opts.password) {
@@ -94,7 +94,7 @@ function getECRAuthToken(
 async function getAuthHeaders(
   registry: string,
   repository: string
-): Promise<OutgoingHttpHeaders | null> {
+): Promise<GotHeaders | null> {
   try {
     const apiCheckUrl = `${registry}/v2/`;
     const apiCheckResponse = await got(apiCheckUrl, { throwHttpErrors: false });
@@ -105,10 +105,12 @@ async function getAuthHeaders(
       apiCheckResponse.headers['www-authenticate']
     );
 
-    const opts: hostRules.HostRule & {
-      headers?: Record<string, string>;
-    } = hostRules.find({ hostType: id, url: apiCheckUrl });
-    opts.json = true;
+    // TODO: fix types
+    const opts: any = hostRules.find({
+      hostType: id,
+      url: apiCheckUrl,
+    });
+    opts.responseType = 'json';
     if (ecrRegex.test(registry)) {
       const [, region] = ecrRegex.exec(registry);
       const auth = await getECRAuthToken(region, opts);
@@ -135,7 +137,9 @@ async function getAuthHeaders(
     logger.trace(
       `Obtaining docker registry token for ${repository} using url ${authUrl}`
     );
-    const authResponse = (await got(authUrl, opts)).body;
+    const authResponse = (
+      await got<{ token?: string; access_token?: string }>(authUrl, opts)
+    ).body;
 
     const token = authResponse.token || authResponse.access_token;
     // istanbul ignore if
@@ -273,7 +277,7 @@ async function getManifestResponse(
  *  - Return the digest as a string
  */
 export async function getDigest(
-  { registryUrls, lookupName }: GetReleasesConfig,
+  { registryUrls, lookupName }: PkgReleaseConfig,
   newValue?: string
 ): Promise<string | null> {
   const { registry, repository } = getRegistryRepository(
@@ -346,7 +350,10 @@ async function getTags(
     }
     let page = 1;
     do {
-      const res = await got<{ tags: string[] }>(url, { json: true, headers });
+      const res = await got<{ tags: string[] }>(url, {
+        responseType: 'json',
+        headers,
+      });
       tags = tags.concat(res.body.tags);
       const linkHeader = parseLinkHeader(res.headers.link as string);
       url =
@@ -413,20 +420,20 @@ async function getTags(
 
 export function getConfigResponse(
   url: string,
-  headers: OutgoingHttpHeaders
+  headers: GotHeaders
 ): Promise<GotResponse> {
   return got(url, {
     headers,
     hooks: {
       beforeRedirect: [
-        (options: any): void => {
+        (options: RenovateGotNormalizedOptions): void => {
           if (
-            options.search &&
-            options.search.indexOf('X-Amz-Algorithm') !== -1
+            options.url.search &&
+            options.url.search.indexOf('X-Amz-Algorithm') !== -1
           ) {
             // if there is no port in the redirect URL string, then delete it from the redirect options.
             // This can be evaluated for removal after upgrading to Got v10
-            const portInUrl = options.href.split('/')[2].split(':')[1];
+            const portInUrl = options.url.href.split('/')[2].split(':')[1];
             if (!portInUrl) {
               // eslint-disable-next-line no-param-reassign
               delete options.port; // Redirect will instead use 80 or 443 for HTTP or HTTPS respectively
@@ -587,7 +594,7 @@ async function getLabels(
 export async function getPkgReleases({
   lookupName,
   registryUrls,
-}: GetReleasesConfig): Promise<ReleaseResult | null> {
+}: PkgReleaseConfig): Promise<ReleaseResult | null> {
   const { registry, repository } = getRegistryRepository(
     lookupName,
     registryUrls

lib/datasource/galaxy/index.ts

@@ -37,7 +37,7 @@ export async function getPkgReleases({
 
   try {
     let res: any = await got(galaxyAPIUrl, {
-      hostType: id,
+      context: { hostType: id },
     });
     if (!res || !res.body) {
       logger.warn(

lib/datasource/go/index.ts

@@ -34,12 +34,12 @@ async function getDatasource(goModule: string): Promise<DataSource | null> {
   try {
     const res = (
       await got(pkgUrl, {
-        hostType: id,
+        context: { hostType: id },
       })
     ).body;
-    const sourceMatch = res.match(
-      regEx(`<meta\\s+name="go-source"\\s+content="${goModule}\\s+([^\\s]+)`)
-    );
+    const sourceMatch = regEx(
+      `<meta\\s+name="go-source"\\s+content="${goModule}\\s+([^\\s]+)`
+    ).exec(res);
     if (sourceMatch) {
       const [, goSourceUrl] = sourceMatch;
       logger.debug({ goModule, goSourceUrl }, 'Go lookup source url');

lib/datasource/gradle-version/index.ts

@@ -35,8 +35,8 @@ export async function getPkgReleases({
     versionsUrls.map(async url => {
       try {
         const response: GradleRelease = await got(url, {
-          hostType: id,
-          json: true,
+          responseType: 'json',
+          context: { hostType: id },
         });
         const releases = response.body
           .filter(release => !release.snapshot && !release.nightly)

lib/datasource/helm/index.ts

@@ -17,7 +17,10 @@ export async function getRepositoryData(
   }
   let res: any;
   try {
-    res = await got('index.yaml', { hostType: id, baseUrl: repository });
+    res = await got('index.yaml', {
+      prefixUrl: repository,
+      context: { hostType: id },
+    });
     if (!res || !res.body) {
       logger.warn(`Received invalid response from ${repository}`);
       return null;

lib/datasource/hex/index.ts

@@ -27,12 +27,12 @@ export async function getPkgReleases({
   const hexPackageName = lookupName.split(':')[0];
   const hexUrl = `https://hex.pm/api/packages/${hexPackageName}`;
   try {
-    const response = await got(hexUrl, {
-      json: true,
-      hostType: id,
+    const response = await got<HexRelease>(hexUrl, {
+      responseType: 'json',
+      context: { hostType: id },
     });
 
-    const hexRelease: HexRelease = response.body;
+    const hexRelease = response.body;
 
     if (!hexRelease) {
       logger.warn({ datasource: 'hex', lookupName }, `Invalid response body`);

lib/datasource/maven/index.spec.ts

@@ -38,12 +38,15 @@ const config = {
 
 describe('datasource/maven', () => {
   beforeEach(() => {
+    global.repoCache = {};
+    hostRules.clear();
     hostRules.add({
       hostType: maven.id,
       hostName: 'frontend_for_private_s3_repository',
       username: 'username',
       password: 'password',
     });
+    nock.cleanAll();
     nock.disableNetConnect();
     nock('http://central.maven.org')
       .get('/maven2/mysql/mysql-connector-java/maven-metadata.xml')
@@ -173,7 +176,7 @@ describe('datasource/maven', () => {
     it('should throw registry-failure if maven-central fails', async () => {
       nock('http://central.maven.org')
         .get('/maven2/org/artifact/maven-metadata.xml')
-        .times(4)
+        .times(3)
         .reply(503);
 
       expect.assertions(1);