feat(deps): upgrade to got v10

[szmarczak]

• json: true -> responseType: 'json'
• body: {...} -> json: {...}
• got.create({options: {}, handlers: [...]}) -> got.extend({handlers: [...]})
• baseUrl -> prefixUrl (breaking change: prefixUrl will be always prepended, so set it to '' when you pass an absolute URL)

Please note that I might have missed something, so please double check.

Note: I don't have the time to correct the typings, but this PR is a good start.

---

TODO

• refactor platform api options
• refactor err.statusCode to res.response?.statusCode
• fix tests

[viceice]

ok, thanks. I'll take this commit and push it to an internal branch and close this pr.

[viceice]

@szmarczak How can i extend the default Options type with custom properties?

We need this to pass custom properties to our got handlers.

[viceice]

@szmarczak How to update the retries function?

renovate/lib/datasource/rubygems/retriable.ts

Lines 38 to 63 in 0eb616f

	export default (numberOfRetries = NUMBER_OF_RETRIES): got.RetryFunction => (
	_?: number,
	err?: Partial<HTTPError>
	): number => {
	if (numberOfRetries === 0) {
	return 0;
	}
	const { headers, statusCode } = err;
	// https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After
	const isBanned = [TOO_MANY_REQUEST, SERVICE_UNAVAILABLE].includes(statusCode);
	const delaySec = isBanned
	? getBannedDelay(headers['retry-after'])
	: getDefaultDelay(numberOfRetries);
	// eslint-disable-next-line
	numberOfRetries--;
	const errorMessage = getErrorMessage(statusCode);
	const message = `${errorMessage} Retry in ${delaySec} seconds.`;
	logger.info(message);
	return delaySec * 1000;
	};

renovate/lib/datasource/rubygems/get.ts

Lines 44 to 55 in 0eb616f

	const json = true;
	const retry = { retries: retriable() };
	const headers = getHeaders();
	const name = `${path}/${dependency}.json`;
	const baseUrl = registry;
	logger.trace({ dependency }, `RubyGems lookup request: ${baseUrl} ${name}`);
	const response = (await got(name, { retry, json, baseUrl, headers })) || {
	body: undefined,
	};

[szmarczak]

How can i extend the default Options type with custom properties?

I'd recommend going with the context option since Got 10 is confused which typing it should choose when you cast the options as GotOptions.

[szmarczak]

How to update the retries function?

Currently I'm not able to rewrite it for you, but will do in an hour. Here's the docs:

https://github.com/sindresorhus/got/blob/master/readme.md#retry

[viceice]

ok, found context and use it, now i only need help at retries.

[viceice]

@szmarczak can you retarget the pr to szmarczak/got-10 when you pushed your changes? Thanks.

[szmarczak]

can you retarget the pr to szmarczak/got-10 when you pushed your changes?

Did you mean "when you push"? If so, then sure, will do :)

Unfortunately I'm not able to convert the retries logic today. Gonna do that tomorrow. I hope you don't mind the waiting.

[viceice]

yes, i can't retarget pr if my branch is infornt of yours 😅 No hurry, i'm done with most type changes. Now fixing some tests, which i won't finish today.

@rarkins How urgnet is this upgrade? I've seen the got issue above.

[viceice]

@szmarczak Another type difficulty. your types say Options.context is always defined, but our tests failed on that. Maybe contect should be defined as optional?

[viceice]

needs retargetting to szmarczak/got-10 🙃

[viceice]

ok 9 tests to got. 😴 🙃

https://app.circleci.com/jobs/github/renovatebot/renovate/20165/tests

[szmarczak]

Another type difficulty. your types say Options.context is always defined

If think you're confusing Options with NormalizedOptions. According to this piece of code it is always defined. If it isn't just please point it out at some piece of code, I'd love to help :)

yes, i can't retarget pr if my branch is infornt of yours

Neither can I. But will do when I pull your changes and commit mine.

[rarkins]

@rarkins How urgnet is this upgrade? I've seen the got issue above.

Not urgent. I think I've managed to fix the problem in got@9

[viceice]

@rarkins ok

@szmarczak I've pushed my changes to your branch now, so we can see what's missing.

[viceice]

9 tests failed

https://app.circleci.com/jobs/github/renovatebot/renovate/20172/tests

[viceice]

@szmarczak Can nock be the problem for the failing tests?

All failing tests use nock for mocking net requests.

[viceice]

Ok, i have to refactor all got wrapper for platforms, as they mix options the old way

[szmarczak]

Can nock be the problem for the failing tests?

A very small chance. I don't think so.

I'll fix the retries today in the afternoon when I'm back from school.

[viceice]

I can't find the cause for the failing maven / sbt tests

[viceice]

I've fixed some inconsistencies. I'll porting them to a seperate pr.

[viceice]

Fixed all tests 💪

Maybe some coverage is now missing. I'll add tests then.

[viceice]

Strange, I don't get the lint errors on my local windows 10. 🤔

[JamieMagee]

@szmarczak I think this PR is mostly superseded by #5841. Unfortunately I don't think it's worth rebasing or merging master with these changes. Instead, I think starting from current master would be easier. Sorry about that!

If you disagree, leave a comment and I can reopen this issue.

[szmarczak]

That's ok, Got 11 is about to be released - compared to Got 10 it is a huge improvement. The API is almost the same.