Issue #249: sanitize existing source bundle manifest #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ie8d16185942228b730b0e143ea551918ed2614b6
sparsick
requested changes
May 8, 2021
| */ | ||
| private void sanitizeSourceManifest(Manifest manifest) { | ||
| Attributes attributes = manifest.getMainAttributes(); | ||
| if (!attributes.isEmpty()) { |
There was a problem hiding this comment.
Please use Stream API:
attributes.keySet().removeIf(header -> Arrays.asList(Analyzer.EXPORT_PACKAGE,
Analyzer.EXPORT_SERVICE, Analyzer.PROVIDE_CAPABILITY ).contains(header));
|
@emweber Thank you for your PR. Please add a unit test or an integration test, if it is easier to write. |
Change-Id: Ie8d16185942228b730b0e143ea551918ed2614b6
Change-Id: Ie8d16185942228b730b0e143ea551918ed2614b6
|
I checked this PR locally and it ran successfully. Currently, the Github Action sucks a little. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ie8d16185942228b730b0e143ea551918ed2614b6