-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Sanitize broken manifest in source bundles #249
Comments
Hi @emweber, IMHO the manifest of the source jar and the "normal" jar should be identical. Therefore, I would prefer the Do you want to create a PR for solving this issue? |
Well, I forgot to explicitly mention that in case of What if p2-maven-plugin would always automatically detect broken source-bundles and re-writes the manifest then? |
Hi @emweber, your idea that p2 maven plugin could detect broken source-bundle is good. P2 Maven plugin could log a warning if it finds it. But I struggle with the rewriting the manifest automatically, because it fights only a symptom and fighting symptoms should be a conscious decision by the developer to rewrite the manifest. Nevertheless, I would prefer the |
Hi Sandra, |
Hi @emweber, yes... please update the issue title. |
@emweber Thank you for your contribution. I released a new version 1.7.0. with your PR. So in the next hours it should be available on Maven Central. |
Hi @emweber, This is great and I just had a similar case, but wondering if there are any reasons why only removing the exports? |
Some artifacts on central are already OSGI-bundles, but their source-bundle mainfest is broken; i.e the source bundle claims to export the same packages as the bundle. This causes p2 to resolve to the source-bundle instead of the real bundle jar.
I found that the source bundle of
org.jboss.spec.javax.annotation:jboss-annotations-api_1.3_spec:2.0.1.Final
is broken.Specifying the
<override>
option did not help to fix the source-bundle manifest.It would be useful if the
<override>
option would also process the source bundle or if there is a separate option to force manifest re-generation for source bundles only.The text was updated successfully, but these errors were encountered: