Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wakatime plugin insead of using extraPlugins #91

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

rollf
Copy link
Contributor

@rollf rollf commented Jun 10, 2024

This could be merged once Neve is updated to use a nixvim verion that is includes this PR. Untested.

Thanks for the great work, I started using Neve using last week and the experience has been fantastic so far.

@rollf rollf changed the base branch from main to dev June 10, 2024 04:27
@rollf
Copy link
Contributor Author

rollf commented Jun 10, 2024

Mh, I changed the target branch from main to dev. However, I started branching from main in the first place. Not sure what is correct here.

@redyf
Copy link
Owner

redyf commented Jun 12, 2024

This could be merged once Neve is updated to use a nixvim verion that is includes this PR. Untested.

Thanks for the great work, I started using Neve using last week and the experience has been fantastic so far.

Hello rollf, sorry for the late reply. I'm glad you liked it! I'll update Neve to a newer nixvim version.

@redyf
Copy link
Owner

redyf commented Jun 12, 2024

Mh, I changed the target branch from main to dev. However, I started branching from main in the first place. Not sure what is correct here.

First of all thanks for the contribution, but you'll need to fix those commits as they contain some stuff that has been merged already.

@rollf
Copy link
Contributor Author

rollf commented Jun 13, 2024

Okay, I rebased my branch on dev. Now, there is only a single commit left. I hope I understood you correctly.

@redyf redyf marked this pull request as ready for review June 13, 2024 13:44
@redyf redyf merged commit 0a1adc2 into redyf:dev Jun 13, 2024
1 of 2 checks passed
@redyf
Copy link
Owner

redyf commented Jun 13, 2024

Okay, I rebased my branch on dev. Now, there is only a single commit left. I hope I understood you correctly.

It was exactly that, thanks again for your contribution 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants