Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/wakatime: init #1652

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

GaetanLepage
Copy link
Member

Add support for vim-wakatime.
This module is quite barebone, but at the same time, there is no need to do much.

Fixes #1649

@GaetanLepage GaetanLepage requested a review from a team June 8, 2024 17:46
@GaetanLepage
Copy link
Member Author

Note: the wakatime-cli dependency gets downloaded automatically by the plugin.
This does not even pose problem on NixOS as it is a statically linked binary.

@MattSturgeon
Copy link
Member

MattSturgeon commented Jun 8, 2024

Note: the wakatime-cli dependency gets downloaded automatically by the plugin. This does not even pose problem on NixOS as it is a statically linked binary.

I'm sure you're aware already, but the cli is available in nixpkgs, we could include that version if there is a way to disable the vim plugin's autodownload.

If it's entirely statically linked (including libc, etc) that's not a big deal though.

EDIT:
I'm not fluent in vimscript, but this line makes me think we can set the cli_already_setup global before loading the plugin...
The plugin later checks that in SetupCLI.

@GaetanLepage
Copy link
Member Author

I agree, we could, but is it worth the hassle ?
I have checked, and the plugin does work fine with the auto-install.

@GaetanLepage
Copy link
Member Author

Maybe we could have an option to let the user choose...

Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we could, but is it worth the hassle ?
I have checked, and the plugin does work fine with the auto-install.

If everything works fine then this isn't a major concern for now.

Maybe we could have an option to let the user choose...

Some purists may like to have as much as possible installed in a deterministic way at build time, however that's something we could revisit later.

LGTM!

@GaetanLepage
Copy link
Member Author

Some purists may like to have as much as possible installed in a deterministic way at build time, however that's something we could revisit later.

Definitely !

@GaetanLepage GaetanLepage merged commit 70088f6 into nix-community:main Jun 8, 2024
55 checks passed
@GaetanLepage GaetanLepage deleted the wakatime branch June 8, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PLUGIN REQUEST] wakatime
2 participants