-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run "yarn rw-gen" during create redwood app #2770
Conversation
One area where our create-redwood-app.js script fails is that we assume I'm curious if we'll have the same issue here where |
Nice! Maybe we can add |
@thedavidprice linking #1954 just cause you mentioned that there too, and it does indeed fail if yarn install isn't true which is definitely not ideal.
^ I'll see if I can include this here |
@jtoar Could you try the ts-stuff in a different PR? I would like to get this one in alongside the eslint PR. |
@peterp Absolutely; I can go ahead and rebase this one it if it looks ready |
I included a check for enabled: () => typescript === false,
skip: () => {
if (yarnInstall === false) {
return 'skipped; needs ts-to-js binary'
}
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too!
* run rw-gen after ts-to-js * skip if install is skipped * skip instead of disable * generate ts project if yarn install is false Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
TypeScript Redwood Apps (created with
yarn create redwood-app --ts
) can't find theNotFoundPage
in the Routes.tsx file because the types haven't been generated yet (#2754). This PR fixes this by generating the types as a part of the install.I think the types are supposed to help JS projects too, so I made it so that they're generated for JS projects as well on install.