-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ts-to-js
transpiling within create-redwood-app.js (instead of the current separate CLI command)
#1954
Comments
Scratch that. I wrote this after diagnosing QA problems but hadn't looked at the GitHub runner. Confirming we are testing this command in the CI Check. The |
Sorry that this isn't as intuitive as I imagined, the reason why we're doing this is because we don't install the packages once the project is created. This means the We copy the packages from the framework and then install everything, then we convert it. If you do Options:
--version Show version number [boolean]
--create-project, --create [boolean] [default: true]
--copy-framework, --copy [boolean] [default: true]
--js-project, --js [boolean] [default: true]
--auto-start, --start [boolean] [default: true]
--help Show help [boolean]
Examples:
run-cypress
run-cypress /tmp/redwood-app --no-js-project Not supplying any options does everything standard; so in your case I think you want to point it to an existing project?
|
It made sense why once I went through the CI workflow along with command. Thanks! Yes, that's what I did. Then upgraded to canary and then ran ts-to-js. Confirming it all worked. |
I can also make the code that transpiles the TS to JS part of Re-opening with that as the task. |
yarn rw ts-to-js
to E2E script (and checks)ts-to-js
code instead of making it a separate command.
@peterp bumping this one. I think your comment above about transpiling as part of CRWA is the right way to go. Updating title. |
ts-to-js
code instead of making it a separate command.ts-to-js
transpiling within create-redwood-app.js (instead of the current separate CLI command)
Another issue this will resolve --> Currently it's impossible to run |
@jtoar Thoughts on closing this one out? We now include both js and ts templates in the create redwood app package and simply copy over the relevant template at install time - no transpilation needed. I think this meets the general theme of this issue. |
@Josh-Walker-GM good call! |
Currently, we skip the
...rw ts-to-js
command in the current E2E tests, which is good for testings a TS project. However, since this is a critical path and the default for new project installation, it seems to me we should include it. And I don't believe the E2E tests will differ based on project being TS or JS, will it?A simple way would be to change this line by removing
--no-javascript
flag:redwood/tasks/run-e2e
Line 43 in 5dbb9e0
Is there reason to not do this here? If so, where else could we add the test?
The text was updated successfully, but these errors were encountered: