-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port test-tutorial script to JS #1896
Conversation
Skipping changing the linking to rwt link, because it actually makes the code a lot more complicated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some stylistic suggestions.
Co-authored-by: Peter Pistorius <peter.pistorius@gmail.com>
18ab40c
to
d156259
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts the desired behavior when providing a path to an existing project to use the project's installed packages — currently, it links and uses branch packages.
I'll take a look at the code to see if I can adjust.
@thedavidprice gotcha! Pushing up fix 2 mins :) |
…e/port-test-2-js * 'e2e/port-test-2-js' of github.com:dac09/redwood: Fixes marshalling datetimes in and out of forms (redwoodjs#1906)
What?
As part of running e2e tests in CI, this PR ports test-tutorial bash script to javascript, to make it more cross-platform compatible
Related to #1895
Working towards #1886