Port test-tutorial script to JS #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping changing the linking to rwt link, because it actually makes the code a lot more complicated! |
Tobbe
reviewed
Mar 2, 2021
peterp
approved these changes
Mar 4, 2021
Co-authored-by: Peter Pistorius <peter.pistorius@gmail.com>
dac09
force-pushed
the
e2e/port-test-2-js
branch
from
18ab40c
to
d156259
Compare
thedavidprice
requested changes
Mar 4, 2021
@thedavidprice gotcha! Pushing up fix 2 mins :) |
…e/port-test-2-js * 'e2e/port-test-2-js' of github.com:dac09/redwood: Fixes marshalling datetimes in and out of forms (redwoodjs#1906)
thedavidprice
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As part of running e2e tests in CI, this PR ports test-tutorial bash script to javascript, to make it more cross-platform compatible
Related to #1895
Working towards #1886