Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Peter Pistorius <peter.pistorius@gmail.com>
  • Loading branch information
dac09 and peterp committed Mar 4, 2021
1 parent 8c3e76f commit d156259
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ module.exports = {
'packages/testing/src/**',
'packages/eslint-config/*.js',
'packages/eslint-plugin-redwood/src/**',
'tasks/**',
],
env: {
es6: true,
Expand Down
14 changes: 10 additions & 4 deletions tasks/test-tutorial.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/* eslint-env node, es6*/

import fs from 'fs'
import os from 'os'
import path from 'path'
Expand Down Expand Up @@ -25,10 +27,11 @@ const testTutorial = async () => {
})

if (pathToProject) {
console.log(
`\n 🗂️ You have supplied the path ${projectPath}, we will not create a new `
)
console.log('Redwood project, we will use the app you have specified.')
console.log([
'🗂️ You have supplied the path "${projectPath}",'
'because of this we assume that there is a pre-existing Redwood project at this path,'
'so we will not create a new redwood project.'
].join('\n'))
} else {
console.log('\n ℹ️ You have not supplied a path to a Redwood project.')
console.log('We will create one for you. \n \n')
Expand All @@ -39,6 +42,7 @@ const testTutorial = async () => {
// Use temporary project path, because no user supplied one
projectPath = fs.mkdtempSync(path.join(os.tmpdir(), 'redwood-e2e-'))

console.log('------------------------ start create redwood app -------------------------')
await execa(
'yarn babel-node',
['src/create-redwood-app.js', projectPath, '--no-yarn-install'],
Expand All @@ -49,6 +53,8 @@ const testTutorial = async () => {
}
)
}



// Clean and build framework
await execa('yarn build:clean && yarn lerna run build:js', {
Expand Down

0 comments on commit d156259

Please sign in to comment.