-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs Rewrite] Remove "Using Immutable.js" page #4053
Conversation
Deploy preview for redux-docs ready! Built with commit 03c835d |
Thanks for filing this! First observation: no, Immer and Immutable.js are not swappable for each other directly. They both operate in the same space (providing ways to immutably update values, and preventing accidental mutations), but they take very different approaches:
So, same problem space, very different approaches. If you're using Immutable.js already, it takes a bunch of work to migrate over to using Immer instead. |
Co-authored-by: Mark Erikson <mark@isquaredsoftware.com>
Thanks for the explanation! |
Y'know, let's just delete everything under the "Immutable Data" header in the "Ecosystem" page except for Immer. None of those other libs are relevant any more now that Immer exists. (and yeah, marking comments as "resolved" is fine if you've made the relevant changes) |
Heh, I love pasting in old URLs into previews and watching the redirects kick in :) Awright, this is probably good enough for now. Thanks, really appreciate you doing this! |
Former-commit-id: 2e9a2d4
Name: 📖 New/Updated Documentation Content
About: Adding a new docs page, or updating content in an existing docs page
PR Type
Does this PR add a new page, or update an existing page?
Checklist
What docs page is being added or updated?
For Updating Existing Content
Do these updates change any of the assumptions or target audience? If so, how do they change?
Updated the recommendation of Immutable.js to be Immer, I have assumed these libraries are hot-swappable and replacements for each other. It is critical to confirm this as otherwise, wording may need to be changed.
Please see below key comments on changes I have made that should be questioned.
docs/FAQ.md -
Deleted references to using Immutable.JS with Redux.
Changed "Do I have to use Immutable.JS" to "Do I have to use Immer" - Is this correct still?
docs/faq/ImmutableData.md -
JavaScript Immutability presentation PDF - Does mention Immutable.js, however,
it also provides solid understandings of immutability so I think it is worth keeping it?
Under "What approaches are there for handling data immutability? Do I have to use Immer?",
I have kept the original Immutable.JS description, are these libraries swappable and the description is still correct?
docs/recipes/structuring-reducers/BeyondCombineReducers.md -
website/_redirects -