-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs Rewrite] Remove "Using Immutable.js" page #4052
Comments
Could the redirect go to https://redux.js.org/style-guide/style-guide#use-immer-for-writing-immutable-updates ? Edit: I think you stated that above actually! |
Sure, go ahead! In theory, the necessary changes are:
|
And fixed by #4053 . |
The Using Immutable.js with Redux page was originally submitted by a user who was enthusiastic about that library. Since they put the time into writing it, and it was relevant, we merged it.
Since then, the situation has changed considerably. We now specifically recommend that you should use Immer and you should not use Immutable.js.
So, it's time to remove that Immutable.js docs page entirely.
The only real question is what redirect we should add to ensure that incoming links pointing to that page end up at a real location. Maybe point to the "Use Immer" Style Guide link? Note that this should be done by specifically adding a line to
website/_redirects
that lists the old URL (and probably has a*
splat in it), and points to the new URL.We may also need to make updates to the "Immutable Data" FAQ page as well to remove any existing references to Immutable.js (and may want to add a new entry on that page that says "Should I Use Immutable.js? No, because...").
The text was updated successfully, but these errors were encountered: