Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Rewrite] Meta-Issue: Recipes section #3596

Open
2 of 13 tasks
markerikson opened this issue Oct 29, 2019 · 10 comments
Open
2 of 13 tasks

[Docs Rewrite] Meta-Issue: Recipes section #3596

markerikson opened this issue Oct 29, 2019 · 10 comments
Labels
Milestone

Comments

@markerikson
Copy link
Contributor

markerikson commented Oct 29, 2019

This is a tracking issue to cover all work related to rewriting the "Recipes" section.

Tasks

@markerikson
Copy link
Contributor Author

While there wasn't a specific issue for it, I wound up making some major updates to the "Usage with TypeScript" page in #3633 after having finished merging in the new React-Redux "Static Typing" page.

@JustFly1984
Copy link

I would consider immutable.js as dead project. @leebayron does not respond to issues and PR since long time ago, and there is no maintainers, and a lot of bugs. I've replaced immutable.js with immer, and I'm very happy about it, except it has no structural sharing :/ Also I had a lot of issues with Typescript integration, and I consider immutable.js exhaustingly developer unfriendly.

@markerikson
Copy link
Contributor Author

Yeah, we now explicitly recommend use of Immer (plus RTK), and I've recommended against using Immutable.js for years.

I'm inclined to drop that page entirely, and just have a small section in an "Immutability" page that says "You can use it if you want, but we don't specifically support or encourage using it".

@markerikson
Copy link
Contributor Author

Having said that, I just looked at the analytics. Since June 1, we've had 627K hits to /, and 589K hits to "Getting Started". The "Using Immutable.js" page has 27K hits. That's only like 0.44% of traffic, but it is a rather non-zero number.

Still, I don't see a reason to keep it around long-term. Maybe we can link to the existing Markdown page in the repo if folks want to read it in more detail, for historical interest.

@joshribakoff
Copy link

+1 for not endorsing immutable.js, its a great lib I'm sure, but I've seen that it confuses newcomers who don't understand the difference between writing reducers to be immutable, and using persistent data structures to do so. Some people incorrectly conclude that you must use immutable.js to have "proper" immutable code.

@DzhideX
Copy link

DzhideX commented Jul 11, 2020

This sounds simple enough:

Move "Configuring Your Store" to "RWU"

Though I don't understand what "RWU" is supposed to mean. The closest thing I can find is the real-world folder under redux/examples. Any guidance?

If this is indeed more complicated than it sounds then I'm open for suggestions!

@markerikson
Copy link
Contributor Author

That's short for the notional new "Real World Usage" category.

For more details, see the extended "how I want to reorganize everything" comment here:

#3313 (comment)

I'm also debating calling it the "Usage Guide" category instead.

Note that any page renames / moving will require also setting up Netlify redirects in the website/_redirects file, so that old external links will get redirected to the new page URLs.

@emgoto
Copy link

emgoto commented Jul 20, 2020

Hi! What could I help out with from here?

@markerikson
Copy link
Contributor Author

@emgoto Appreciate you volunteering to help :)

Tell you what. How about going back to my original notes on the docs rewrite at #3313 (comment) , see what I actually wrote there about the RWU section, pull that in here, and let's see if we can come up with a more specific plan for how we want to organize this stuff. I'm thinking we'd probably want some sub-categories in here, like maybe "Setup" would contain "Configuring Your Store", "Usage with TS", etc, but not sure on details yet.

Related: I'm not 100% sure I actually want to stick with the name "Real World Usage". Right now, the React-Redux docs have a "Using React-Redux" section (/using-react-redux/), and the Redux Toolkit docs have "Using Redux Toolkit" (/usage/). "Real World Usage" might be okay, but I'm wondering if maybe just "Usage Guides" would be better?

@nickserv
Copy link
Contributor

nickserv commented Sep 1, 2020

It would be nice to migrate the recipes to hooks as well (I updated the testing one in #3876). Would a separate issue be better or would you like to add it to this list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants