Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document update regarding addressResolverGroup settings #3007

Merged
merged 6 commits into from
Oct 18, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update doc
winguse authored Oct 7, 2024

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
commit 8956e5dc796bf6db05ac057ceae60f45384f4472
3 changes: 1 addition & 2 deletions docs/advanced-usage.md
Original file line number Diff line number Diff line change
@@ -201,7 +201,6 @@ events are emitted by default every 10 minutes. Event publishing can be
disabled by setting <code>commandLatencyPublisherOptions(…)</code> to
<code>DefaultEventPublisherOptions.disabled()</code>.</td>
</tr>

<tr>
<td><strong>DNS Resolver</strong></td>
<td><code>dnsResolver</code></td>
@@ -235,7 +234,7 @@ netty's <code>AddressResolver</code> that resolves DNS names on
<code>io.netty.resolver.DefaultAddressResolverGroup#INSTANCE</code> if <code>netty-dns-resolver</code>
is not available, otherwise defaults to <code>io.netty.resolver.dns.DnsAddressResolverGroup</code></p>
<p>Users of DNS-based Redis-HA setups (e.g. AWS ElastiCache) might want to configure a different DNS
resolver. For example: <pre>
resolver group. For example: <pre>
DnsNameResolverBuilder builder = new DnsNameResolverBuilder();
builder.resolveCache(NoopDnsCache.INSTANCE);
builder.cnameCache(NoopDnsCnameCache.INSTANCE);
Original file line number Diff line number Diff line change
@@ -442,7 +442,7 @@ public Builder computationThreadPoolSize(int computationThreadPoolSize) {

/**
* Sets the {@link DnsResolver} that is used to resolve hostnames to {@link java.net.InetAddress}. Defaults to
* {@link DnsResolvers#JVM_DEFAULT}
* {@link DnsResolvers#UNRESOLVED}
*
* @param dnsResolver the DNS resolver, must not be {@code null}.
* @return {@code this} {@link Builder}.