Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document update regarding addressResolverGroup settings #3007

Merged
merged 6 commits into from
Oct 18, 2024
+30 −2
Merged

document update regarding addressResolverGroup settings #3007

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
57e8054
Update advanced-usage.md
winguse Oct 7, 2024
8956e5d
update doc
winguse Oct 7, 2024
6f6382a
update doc
winguse Oct 7, 2024
3e43c44
pr comments (sorry for getting back late)
winguse Oct 16, 2024
32bf339
wrap with actual DnsAddressResolverGroup
winguse Oct 16, 2024
6b642b9
use space
winguse Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
update doc
@winguse
winguse authored Oct 7, 2024

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600
Verified
Learn about vigilant mode
commit 6f6382ab6d16b4ae52a28bb657ff7f0efa1c1bd9
13 changes: 7 additions & 6 deletions docs/advanced-usage.md
View file
Original file line number Diff line number Diff line change
@@ -235,12 +235,13 @@ netty's <code>AddressResolver</code> that resolves DNS names on
is not available, otherwise defaults to <code>io.netty.resolver.dns.DnsAddressResolverGroup</code></p>
<p>Users of DNS-based Redis-HA setups (e.g. AWS ElastiCache) might want to configure a different DNS
resolver group. For example: <pre>
DnsNameResolverBuilder builder = new DnsNameResolverBuilder();
builder.resolveCache(NoopDnsCache.INSTANCE);
builder.cnameCache(NoopDnsCnameCache.INSTANCE);
builder.authoritativeDnsServerCache(NoopAuthoritativeDnsServerCache.INSTANCE);
builder.consolidateCacheSize(0);
new DnsAddressResolverGroup(builder);
new DnsAddressResolverGroup(
new DnsNameResolverBuilder()
.resolveCache(NoopDnsCache.INSTANCE)
.cnameCache(NoopDnsCnameCache.INSTANCE)
.authoritativeDnsServerCache(NoopAuthoritativeDnsServerCache.INSTANCE)
.consolidateCacheSize(0)
);
</pre></p>
</td>
</tr>