throw exception if JedisCluster cannot connect to any host-port #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
commented
Dec 8, 2021
src/test/java/redis/clients/jedis/JedisClusterWithoutSetupTest.java
Outdated
Show resolved
Hide resolved
…nto chinafzy/master
sazzad16
requested review from
gkorland,
chayim,
mina-asham,
dengliming and
yangbodong22011
yangbodong22011
approved these changes
Dec 9, 2021
sazzad16
added
the
breakingchange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #2275
Original author: @chinafzy
If none of the
startNodes, given in JedisCluster constructor, works:User would be instantly aware if an exception is thrown.
Cause of new PR: I don't have write permission in the repo of original PR.
Closes #2275